Show online status indicator and reliably reconnect after going offline

[quinthar]

I don't think we've really proven that we can maintain a reliable Pusher connection yet. This is hard to prove, because I don't always know if I'm connected. So let's create a really visible online status (ie, make the "gray dot" be a "green dot" when connected), and then aggressively test every possible combination of going online/offline to confirm that we always reconnect reliably.

[marcaaron]

Ok, so there is definitely something up with the Pusher connectivity on web. It reads the connected event just fine. But it's not working for the disconnected event. Moving on to other platforms next.

So far I have tried looking into the NetInfo package as a fallback since it apparently should work on web and native. But I'm experiencing issues getting it to work on web.

[marcaaron]

More updates:

• Looks like Pusher's disconnected event is not working on iOS or Web
• Can't seem to get the NetInfo package to work on web
• NetInfo works great on iOS

Going to test Android next...

[marcaaron]

Ok actually the Pusher disconnected event actually just takes a reeeeeeeeally long time before it registers as "disconnected" - something like 10-15 seconds it seems like. I tested this out on our main web app and also in the RN branch I'm working on.

[marcaaron]

The problem I'm seeing with Pusher being "reliable" here.. is that you can completely lose connectivity for about 10-15 seconds, but Pusher won't tell you until that time is up. So that doesn't really help us tell when we are really connected or not.

I think for that we might just need to use the NetInfo library.

[quinthar]

I think this could be a good place to engage with the community and submit upstream PRs to fix these -- as well as just hire contractors (such as our React Native guy) to make improvements here. If it works on iOS and Android, and if we can create a reliable test to show it isn't working on web, then we can just hire someone to fix it (or fix it ourselves). How to libraries work in React, actually -- is it easy for us to just run our own branch? Like, can we import all of the React libraries we care about into our main repo, and easily maintain our own fork of those we've modified, while waiting for it to be accepted upstream?

…

On Wed, Aug 19, 2020 at 5:25 PM Marc Glasser ***@***.***> wrote: The problem I'm seeing with Pusher being "reliable" here.. is that you can completely lose connectivity for about 10-15 seconds, but Pusher won't tell you until that time is up. So that doesn't really help us tell when we are *really* connected or not. I think for that we might just need to use the NetInfo library. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#252 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEMNUTPWTOPWA5USF4HADTSBRUN3ANCNFSM4QFMYINA> .

[marcaaron]

I think this could be a good place to engage with the community and submit
upstream PRs to fix these

Yep, I'll probably create an issue for this if I can't figure it out. But let's not rule out the possibility that I could be holding this wrong because I'm fairly new to the React Native scene 😅

is it easy for us to just run our own branch? Like, can we import all of the React libraries we care about into our main repo, and easily maintain our own fork of those we've modified, while waiting for it to be accepted upstream?

To be honest, I don't have much experience doing what you are describing so I'm not really sure how easy or hard it would be.