[HOLD for payment 2023-09-27] [$1000] "Hm... it's not here" message displays for a moment when viewing deleted money request that has sub-thread

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login to Account A.
2. Send a money request to another account.
3. Open the "IOU preview" >>> then click to view details.
4. Edit the amount and click Save.
5. Return to the "IOU preview" >> a sub-thread will be created after step # 4.
6. Hover over the "IOU Preview" and select the "Delete request" option.
7. Click on the request to open the sub-thread >> Leave Thread.
8. On the LHN: reopen that thread.
9. Observer: A "Hm... it's not here" message displays for a moment.

Expected Result:

We shouldn't allow the person who submitted the request to "leave thread" on their transactions, so that option shouldn't be available.

Actual Result:

"Hm... it's not here" message displays for a moment

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.56-4
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

hmm-not-here-issue.mp4

Recording.387.mp4

Expensify/Expensify Issue URL:
Issue reported by: @tranvantoan-qn
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692707688922459

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0143a231695978749a
• Upwork Job ID: 1694426496996868096
• Last Price Increase: 2023-08-30
• Automatic offers:
• mollfpr | Reviewer | 26455595
• b4s36t4 | Contributor | 26455597
• tranvantoan-qn | Reporter | 26455598

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @puneetlath (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[b4s36t4]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Hm... it's not here" message displays for a moment when viewing deleted money request that has sub-thread

What is the root cause of that problem?

THis bug introduced after #23394 this PR.

Before this PR we have a state isReportRemoved which makes the report to not render FullPageNotFoundView.

After we leave the thread API result null as the value for deleted reportID in which we have {} in onyxDB.

here

App/src/pages/home/ReportScreen.js

Line 295 in aa98b6b

shouldShow={(!this.props.report.reportID && !this.props.report.isLoadingReportActions && !isLoading) || shouldHideReport}

in this line this snippet gets !this.props.report.reportID && !this.props.report.isLoadingReportActions && !isLoading to true because this.props.report is empty object {} which resulting FullPageNotFoundView to be true.

What changes do you think we should make in order to solve the problem?

We add a can check for empty report means the we have removed the report from the our reports.

Updated

!_.isEmpty(this.props.report) && !this.props.report.reportID && !this.props.report.isLoadingReportActions && !isLoading`

would render the loading screen.

What alternative solutions did you explore? (Optional)

NA

Kapture.2023-08-22.at.23.50.59.mp4