[HOLD for payment 2023-09-06] [HOLD for payment 2023-09-04] [$1000] cursor should display as disabled on select all checkbox even if only non removable members are present

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. go to Settings > Workspaces
2. click on new workspace button
3. go to members
4. hover on select all checkbox

Expected Result:

cursor should be display as disabled because there the member is admin

Actual Result:

cursor does not display as disabled

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.57-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-08-23.at.1.48.28.PM.mov

Recording.1502.mp4

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692778734596109

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e6456f8777d856ec
• Upwork Job ID: 1694799760529616896
• Last Price Increase: 2023-08-24

[c3024]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Checkbox does not show disabled cursor when there are no eligible members to be selected

What is the root cause of that problem?

PR #22622 moved the checkbox and select all into the SelectionList but the logic of disabling these was missed which was present in earlier page like this

App/src/pages/workspace/WorkspaceMembersPage.js

Line 460 in b5e309c

disabled={_.isEmpty(removableMembers)}

What changes do you think we should make in order to solve the problem?

We pass

disabled={flattenedSections.allOptions.length === flattenedSections.disabledOptionsIndexes.length}

for this Pressable and the following Checkbox

App/src/components/SelectionList/BaseSelectionList.js

Line 336 in 329cac3

<PressableWithFeedback

What alternative solutions did you explore? (Optional)

We may use the old logic like this
We should pass a prop called disabled to the SelectionList and use it in the Pressable and Checkbox like this.
Add this in WorkspaceMembersPage simlar to the logic in the earlier page.

let removableMembers = {};
    _.each(data, (memberOption) => {
        const member = props.personalDetails[memberOption.keyForList];
        if (member.accountID === props.session.accountID || member.login === props.policy.owner || member.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE) {
            return;
        }
        removableMembers[member.accountID] = member;
    });

and pass

disabled={_.isEmpty(removableMembers)}

here

App/src/pages/workspace/WorkspaceMembersPage.js

Line 385 in 85032a8

<SelectionList

and add default prop

disabled = false

here

App/src/components/SelectionList/BaseSelectionList.js

Line 31 in 85032a8

function BaseSelectionList({

and add

disabled = {disabled}

here

App/src/components/SelectionList/BaseSelectionList.js

Line 336 in 85032a8

<PressableWithFeedback

and here

App/src/components/SelectionList/BaseSelectionList.js

Line 343 in 85032a8

<Checkbox

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @aldo-expensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[c3024]

PR #22622 moved the checkbox and select all into the SelectionList but the logic of disabling these was missed.
We need to add

disabled={flattenedSections.allOptions.length === flattenedSections.disabledOptionsIndexes.length}

to the Pressable and CheckBox.
Detailed proposal here