Workspace - Tooltip is miising on hover in invite members page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to Settings > Workspaces >members
2. Click on invite button
3. Hover on profile pic off

Expected Result:

Should show tooltip with name or email

Actual Result:

Does not show tooltip

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• Windows / Chrome
• MacOS / Desktop

Version Number: 1.3.57-0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-08-23.at.1.17.25.PM.mov

Gravar.2968.mp4

Expensify/Expensify Issue URL:

Issue reported by: @manan Gadhiya

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692776872885369

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @aldo-expensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[aldo-expensify]

Asking here about opinions: https://expensify.slack.com/archives/C01GTK53T8Q/p1692913823483759
I think we should just close this, the old behaviour was useless.

[rushatgabhane]

I think we should fix it because a long email might not be visible in a single line. You can see the complete email in the tooltip. What do you think?

This is probably caused by #22622

[aldo-expensify]

@rushatgabhane agreed, I didn't think of that. And yes, that PR is my suspect too hehe

[dummy-1111]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tooltip isn't shown on hover avatar in invite members page

What is the root cause of that problem?

We don't have tooltip for avatar in the newly refactored SelectionList in this PR

Please check the below code

App/src/components/SelectionList/CheckboxListItem.js

Lines 42 to 49 in 4362fe7

	{Boolean(item.avatar) && (
	<Avatar
	containerStyles={styles.pl5}
	source={lodashGet(item, 'avatar.source', '')}
	name={lodashGet(item, 'avatar.name', item.text)}
	type={lodashGet(item, 'avatar.type', CONST.ICON_TYPE_AVATAR)}
	/>
	)}

What changes do you think we should make in order to solve the problem?

We need to wrap the avatar with the UserDetailsTooltip

        {Boolean(item.avatar) && (
            <UserDetailsTooltip
                accountID={item.accountID}
                icon={item.avatar}
                fallbackUserDetails={{
                    displayName: item.avatar.name,
                    avatar: item.avatar.source,
                }}
            >
                <View>
                    <Avatar
                        containerStyles={styles.pl5}
                        source={lodashGet(item, 'avatar.source', '')}
                        name={lodashGet(item, 'avatar.name', item.text)}
                        type={lodashGet(item, 'avatar.type', CONST.ICON_TYPE_AVATAR)}
                    />
                </View>
            </UserDetailsTooltip>
        )}

This works fine as expected

Result

25895.mp4

What alternative solutions did you explore? (Optional)

[mountiny]

@thiagobrez will cover this one too https://expensify.slack.com/archives/C01GTK53T8Q/p1692975527845569?thread_ts=1692952886.670059&cid=C01GTK53T8Q