[HOLD for payment 2023-10-09] [$500] Chat - User suggestion @ list not appearing on the second

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Launch app
2. Tap on any report
3. Enter @ and from suggestions select an user
4. Tap enter key
5. Enter @

Expected Result:

User suggestions @ list must appear on the second line

Actual Result:

User suggestions @ list not appearing on the second line and only a jump can be seen above composer

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.58-1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

secongtime.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause Internal team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01787235515a8ea167
• Upwork Job ID: 1698842683423707136
• Last Price Increase: 2023-09-11
• Automatic offers:
• cubuspl42 | Reviewer | 26685579
• bernhardoj | Contributor | 26685580

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Typing the second 'at' (@) won't show the mention suggestion.

What is the root cause of that problem?

In our composer, we set an onScroll callback that will hide the suggestion.

App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions.js

Line 493 in 4675db5

onScroll={updateShouldShowSuggestionMenuToFalse}

On Android, when we type the @ in a new line input height changes and it will trigger the onScroll which then hides the suggestion. So, we can briefly see the suggestion animation shows and then immediately hides. On iOS, we can only reproduce this when the composer reaches the maximum line and typing @ moves to the new line. See the video below.

Screen.Recording.2023-08-29.at.22.28.28.mov

What changes do you think we should make in order to solve the problem?

I suggest to remove the onScroll callback to prevent any unintended side effect.

What alternative solutions did you explore? (Optional)

Ignore the onScroll callback if the scrolled is triggered by adding a text to the composer. To do that, we would need to:

1. Create a new ref that holds a bool value to decide whether we should ignore the onScroll or not.
2. In updateComment, set the ref value to be true
3. In onScroll callback function (updateShouldShowSuggestionMenuToFalse), if the ref value is true, do an early return and set the ref value to false.
   

   App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions.js

   Lines 318 to 323 in e25a27f

   	const updateShouldShowSuggestionMenuToFalse = useCallback(() => {
   	if (!suggestionsRef.current) {
   	return;
   	}
   	suggestionsRef.current.updateShouldShowSuggestionMenuToFalse(false);
   	}, [suggestionsRef]);

4. Last, we need to wrap updateShouldShowSuggestionMenuToFalse with a debounce with a 200ms interval because onScroll is triggered multiple times on typing a text.

[alexpensify]

I will review soon

[melvin-bot]

@alexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01787235515a8ea167

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.