[HOLD for payment 2023-11-02] [$1000] Android - letter "g" is cut off from the bottom in the IOU card when the language is spanish

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login the app with 2 different accounts as user A and user B, user A should be on android.
2. As user A, Go to settings> preferences> language> choose spanish.
3. As user B, send a money request to user A.
4. From user A, go to user B chat report and notice the "g" letter in "pagar" is cut off from the bottom in the IOU card.

Expected Result:

"g" letter in "pagar" shouldn't be cut off from the bottom in the IOU card when the language is spanish.

Actual Result:

"g" letter in "pagar" is cut off from the bottom in the IOU card when the language is spanish.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.65-6

Reproducible in staging?: Y

**Reproducible in production?:**Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20230903_233158_New.Expensify.mp4

Screen.Recording.20230907.222432.New.Expensify.mp4

Expensify/Expensify Issue URL:

Issue reported by: @ahmedGaber93

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693773598319289

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0113b4746fa8dbba09
• Upwork Job ID: 1701250408489021440
• Last Price Increase: 2023-09-29

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dummy-1111]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Letter g is cut off in the IOU card when the language is Spanish

What is the root cause of that problem?

The button in IOU card is a ButtonWithDropdownMenu component(in SettlementButton)

In ButtonWithDropdownMenu, we set the button height with StyleUtils.getDropDownButtonHeight function

App/src/styles/StyleUtils.ts

Lines 1172 to 1181 in b119f9a

	function getDropDownButtonHeight(buttonSize: ButtonSizeValue): ViewStyle | CSSProperties {
	if (buttonSize === CONST.DROPDOWN_BUTTON_SIZE.LARGE) {
	return {
	height: variables.componentSizeLarge,
	};
	}
	return {
	height: variables.componentSizeNormal,
	};
	}

As you can see, we limit the button height to 40(for normal button). For normal button, font size is 13, and padding is 16 for both top and bottom. So the text height would be 16. This isn't enough for 13px font

I think the reason that this issue happens only on android is the difference in font rendering between iOS, android, and desktop.

What changes do you think we should make in order to solve the problem?

We have min heights for buttons already here

App/src/styles/styles.js

Line 490 in b119f9a

minHeight: variables.componentSizeSmall,

App/src/styles/styles.js

Line 499 in b119f9a

minHeight: variables.componentSizeNormal,

App/src/styles/styles.js

Line 509 in b119f9a

minHeight: variables.componentSizeLarge,

Solution 1
Don't limit the height of buttons to constants. We can use fit-content instead or simply remove height css.

Solution 2
Remove padding top, padding bottom, and text height and add alignItems: 'center'

This works as expected

Result

What alternative solutions did you explore? (Optional)

[puneetlath]

@Expensify/design thoughts on this? I think it's probably worth fixing if our button height isn't enough for our default font size and padding.

But if we decide to fix it, I'm going to reduce the bounty to $250 since this is a minor design issue rather than a bug that is impeding user action.

[shawnborton]

Yeah we should fix. Any idea why this only affects Android?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0113b4746fa8dbba09

[melvin-bot]

Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.