[HOLD for payment 2023-11-13] [HOLD for payment 2023-10-30] [$500] Update LHN/chat header to handle displayName not being set

[puneetlath]

We are going to stop sending a display name from the back-end in certain scenarios. In those scenarios, we should fall back on using "Hidden" in the LHN and Chat Header (and anywhere else that relies on display name being set).

Let's update any place that expects a display name to fall back on the primary login. And if there is neither a displayName or a primary login, to fall back on "Hidden".

Issue reported by: @parasharrajat
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694550580877519

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011dd93c0b122cf21f
• Upwork Job ID: 1715060740724056064
• Last Price Increase: 2023-10-19

[melvin-bot]

Current assignee @puneetlath is eligible for the NewFeature assigner, not assigning anyone new.

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Update LHN/chat header to handle displayName not being set

What is the root cause of that problem?

We're still returning empty string incase we don't have the value for shortName and longName.

App/src/libs/ReportUtils.js

Lines 1099 to 1107 in d68263a

	function getDisplayNameForParticipant(accountID, shouldUseShortForm = false) {
	if (!accountID) {
	return '';
	}
	const personalDetails = getPersonalDetailsForAccountID(accountID);
	const longName = personalDetails.displayName;
	const shortName = personalDetails.firstName || longName;
	return shouldUseShortForm ? shortName : longName;
	}

What changes do you think we should make in order to solve the problem?

We can add more condition if both of these values are empty, we should use primaryLogin or "Hidden":

    if (_.isEmpty(longName) && _.isEmpty(shortName)) {
        return personalDetails.login || Localize.translate("common.hidden");
    }
    return shouldUseShortForm ? shortName : longName;

What alternative solutions did you explore? (Optional)

N/A

[lukemorawski]

@puneetlath It's Lucas from Callstack. Happy to work on that. Just wanted to clarify one thing. By fallback to "Hidden" you mean displaying a text "Hidden" in the header and LHN?

[puneetlath]

Yes, exactly. Let's have the text "Hidden" be the final fallback text whenever we use display names and aren't able to find either a display name or a login.

[lukemorawski]

@puneetlath How can I create an account with no display name, to test that change?

[puneetlath]

We chatted in Slack, but this will only be testable by adding fake data in Onyx or removing data from an existing user.