[HOLD for payment 2023-10-30] [HOLD for payment 2023-09-29] [$500] Dev: Web - My note not translated in Spanish

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to Settings > Preferences >Language
2. Change Language to Spanish
3. Create workspace if not created
4. Go to #admins
5. Click on header
6. Go to Private notes

Expected Result:

My note should be translated in Spanish

Actual Result:

My note not translated in Spanish

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: Dev 1.3.70.5
Reproducible in staging?: n
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-15.at.7.04.05.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694784868918699

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a01358f997cc9909
• Upwork Job ID: 1703115340291780608
• Last Price Increase: 2023-09-16
• Automatic offers:
• namhihi237 | Contributor | 26746126
• gadhiyamanan | Reporter | 26746127

[namhihi237]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"My note" should be translated when changing language to Spanish

What is the root cause of that problem?

We have some places hard-coding "My note". Therefore, when changing the language to Spanish, they will not be translated.

App/src/pages/PrivateNotes/PrivateNotesEditPage.js

Line 90 in 76c1559

subtitle="My note"

App/src/pages/PrivateNotes/PrivateNotesListPage.js

Line 110 in 76c1559

title: Number(lodashGet(session, 'accountID', null)) === Number(accountID) ? 'My note' : lodashGet(personalDetailsList, [accountID, 'login'], ''),

App/src/pages/PrivateNotes/PrivateNotesViewPage.js

Line 67 in 76c1559

subtitle={isCurrentUserNote ? 'My note' : `${lodashGet(personalDetailsList, [route.params.accountID, 'login'], '')} note`}

What changes do you think we should make in order to solve the problem?

We should make use of translate() and create translations for them.

translate('privateNotes.myNote')

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a01358f997cc9909

[melvin-bot]

Triggered auto assignment to @alexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

My note not translated in spanish

What is the root cause of that problem?

We are missing Localization logic for PrivateNotesFeature in PrivateNotesEditPage.js, PrivateNotesListPage.js and PrivateNotesViewPage.js

What changes do you think we should make in order to solve the problem?

The messages in this feature should refer to en.ts and spanish translation to es.ts

Then we will be using the useLocalize() hook

const {translate} = useLocalize();

to add Localization feature:

subtitle={translate('privateNotes.myNote')}

title: Number(lodashGet(session, 'accountID', null)) === Number(accountID) ? translate('privateNotes.myNote') : lodashGet(personalDetailsList, [accountID, 'login'], 

subtitle={isCurrentUserNote ? translate('privateNotes.myNote') : `${lodashGet(personalDetailsList, [route.params.accountID, 'login'], '')} note`}

What alternative solutions did you explore? (Optional)

[allroundexperts]

@neonbhai How is your proposal different from what @namhihi237 proposed earlier?

[neonbhai]

Hi @allroundexperts, added clear implementation details and line changes.

[allroundexperts]

@neonbhai Adding implementation details with a duplicated approach won't lead to your proposal getting accepted. One can write pseudo code only as well as long as the approach is clear enough. I would suggest you to write proposals that are different from the already existing ones.

[allroundexperts]

@namhihi237's proposal looks good to me!

🎀 👀 🎀 C+ reviewed