[HOLD for payment 2023-10-27] [$500] Android - Scan IOU - A broken image is downloaded to the device when receipt cannot be downloaded

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Launch New Expensify app.
2. Create a Scan IOU.
3. Open the IOU details view.
4. Tap on the receipt > overflow menu > Download.
5. Close the error message.
6. Go to the device gallery.
   Note that a broken image is downloaded despite the error message.

Expected Result:

Nothing will be downloaded to the device since it shows 'Attachment cannot be downloaded' message.

Actual Result:

A broken image is downloaded to the device despite the 'Attachment cannot be downloaded' message.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.72-8

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6208754_Screen_Recording_20230921_105335_Gallery.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause-Internal Team

Slack conversation: @

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0126f987f66d4dbcf0
• Upwork Job ID: 1705133271802134528
• Last Price Increase: 2023-09-22
• Automatic offers:
• bernhardoj | Contributor | 27229717

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[sakluger]

Yep, that's a bug. @izarutskaya do you know what caused it to throw the error?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0126f987f66d4dbcf0

[melvin-bot]

Current assignee @sakluger is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[ayazalavi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

As soon as user try downloading file then error is thrown along with junk file stored.

What is the root cause of that problem?

Root cause exists when we try to copy file in media store which does not exist.

App/src/libs/fileDownload/index.android.js

Lines 75 to 84 in 171259c

	return RNFetchBlob.MediaCollection.copyToMediaStore(
	{
	name: attachmentName,
	parentFolder: 'Expensify',
	mimeType: null,
	},
	'Download',
	attachmentPath,
	);
	})

This results in junk file saved.

What changes do you think we should make in order to solve the problem?

Use RNFetchBlob.fs.exists(attachmentPath) to check if file exists before trying to save the file.

Result:

0e23b2c6-cb5b-4260-b827-af117f8d6127.mp4

What alternative solutions did you explore? (Optional)

We can alternatively check for file system issues happening through the app and fix them all.

[ayazalavi]

Hi @mananjadhav,

I hope you're well. I would like to request your approval for my proposal. If you can provide the approval, I will be able to create the pull request (PR) within the next hour. Your prompt response would be greatly appreciated.

Thank you for your consideration.

Best regards,
Ayaz Alavi