[HOLD for payment 2023-10-12] [HOLD for payment 2023-10-10] [$500] Web - Green drag and drop area does not show in full screen

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click on FAB icon and select Request money
2. Go to scan tab
3. Upload receipt and request money
4. Go to transaction thread
5. Click on image
6. Click on three dots and select replace
7. Try to drop image

Expected Result:

green drag and drop area should show in full screen same as scan tab

Actual Result:

drag and drop area does not cover full screen

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.73-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-20.at.4.46.48.PM.mov

Recording.4683.mp4

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695210899596209

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019a657764a62d532c
• Upwork Job ID: 1705215482777022464
• Last Price Increase: 2023-09-22
• Automatic offers:
• hoangzinh | Reviewer | 26876728
• gadhiyamanan | Contributor | 26876729
• gadhiyamanan | Reporter | 26876731

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

green drag and drop area does not show in full screen

What is the root cause of that problem?

In EditRequestReceiptPage, we don't wrap the header into DragAndDropProvider the same as MoneyRequestSelectorPage. So the green drag and drop area does not show in full screen

App/src/pages/EditRequestReceiptPage.js

Lines 35 to 39 in e52f21a

	<HeaderWithBackButton
	title={translate('common.receipt')}
	onBackButtonPress={Navigation.goBack}
	/>
	<DragAndDropProvider>

What changes do you think we should make in order to solve the problem?

We should move HeaderWithBackButton into DragAndDropProvider

<DragAndDropProvider>
    <HeaderWithBackButton
        title={translate('common.receipt')}
        onBackButtonPress={Navigation.goBack}
    />

    <ReceiptSelector
        route={route}
        transactionID={transactionID}
    />
</DragAndDropProvider>

What alternative solutions did you explore? (Optional)

NA

[ahmedGaber93]

Proposal

Please re-state the problem that we are trying to solve in this issue.

green drag and drop area does not show in full screen in EditRequestReceiptPage.js but it shown in MoneyRequestSelectorPage.js

What is the root cause of that problem?

the root cause is the HeaderWithBackButton is not a child of DragAndDropProvider.

App/src/pages/EditRequestReceiptPage.js

Lines 35 to 44 in 94c07ea

	<HeaderWithBackButton
	title={translate('common.receipt')}
	onBackButtonPress={Navigation.goBack}
	/>
	<DragAndDropProvider>
	<ReceiptSelector
	route={route}
	transactionID={transactionID}
	/>
	</DragAndDropProvider>

What changes do you think we should make in order to solve the problem?

we need to move HeaderWithBackButton inside DragAndDropProvider

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019a657764a62d532c

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @lschurr (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)