[HOLD for payment 2023-10-25] [$500] Correcting one digit in an incorrect magic code instantly resubmits

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to the login page
2. Enter any email/phone number
3. Click continue
4. Enter an incorrect magic code
5. Try to correct the magic code by changing multiple digits

Expected Result:

Users should be able to correct multiple digits in an incorrect magic code. Either we should not resubmit as soon as 1 digit has changed, or we should clear the magic code if it is incorrect allowing users to start from scratch

Actual Result:

As soon as you correct one digit, the magic code is resubmitted, preventing you from changing multiple digits

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.73-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-08-29.at.13.25.59.mov

Recording.1601.mp4

Expensify/Expensify Issue URL:
Issue reported by: @joh42
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693308839489339

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0102290181cc0b5855
• Upwork Job ID: 1705224904962015232
• Last Price Increase: 2023-09-29
• Automatic offers:
• cubuspl42 | Reviewer | 27222383
• saranshbalyan-1234 | Contributor | 27222386
• joh42 | Reporter | 27222387

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0102290181cc0b5855

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @michaelhaxhiu (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[kavimuru]

Proposal from @joh42

Proposal

Please re-state the problem that we are trying to solve in this issue.

When a user edits one digit of an incorrect magic code, the magic code is instantly resubmitted.

What is the root cause of that problem?

As long as there are 6 digits in the magic code, we submit when the magic code changes, regardless of the index of the changed digit.

What changes do you think we should make in order to solve the problem?

I think the approach that makes the most sense would be to only resubmit if the last digit is edited. This could be implemented by:

1. Adding a new ref, called something like lastUpdatedIndex
2. Set lastUpdatedIndex to either focusedIndex/editIndex in onChangeText
3. Add an early return to the props.value useEffect, which is the one that triggers validation when the value has changed (if (lastUpdatedIndex.current !== 5) return;)
4. OPTIONAL: Add a prop regulating the above early return. Perhaps called alwaysSubmitOnChange, defaulting to true but passed as false in the signin BaseValidateCodeForm

This is the useEffect in question:

App/src/components/MagicCodeInput.js

Lines 130 to 131 in 2fbe81d

	useEffect(() => {
	validateAndSubmit();

What alternative solutions did you explore? (Optional)

Alternative 1

Another approach would be to debounce the submission after a digit has been changed. This could easily be done using _.debounce, and then use the debounced function in the aforementioned useEffect. We might only want to do this if the code has already been submitted once, which can be stored in a new ref.

Alternative 2

Yet another approach would be to clear the magic code in case it is incorrect.

[saranshbalyan-1234]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After one try, if user try to edit the magic code it immediately resubmit prevents to change all the code

What changes do you think we should make in order to solve the problem?

We can avoid auto-submission of magic code, after the initial submit.

What that means is, once the user submits the magic-code and then changes the magic-code in anyway, whether he removes some digit, or changes any digit (including last digit as well) the application wont submit the magic-code automatically.

Now User have to manually click on signin or submit button to get logged in.

How To Achieve this Scenario:
We can just maintain another state i.e. firstSubmit forExample with initial value as true and once we call validateAndSubmit we will set the value as false

Create this state here

App/src/components/MagicCodeInput.js

Lines 93 to 97 in 65fd435

	function MagicCodeInput(props) {
	const inputRefs = useRef([]);
	const [input, setInput] = useState('');
	const [focusedIndex, setFocusedIndex] = useState(0);
	const [editIndex, setEditIndex] = useState(0);

    const [firstSubmit, setFirstSubmit] = useState(true)

and change this to this

App/src/components/MagicCodeInput.js

Lines 116 to 126 in 65fd435

	const validateAndSubmit = () => {
	const numbers = decomposeString(props.value, props.maxLength);
	if (!props.shouldSubmitOnComplete || _.filter(numbers, (n) => ValidationUtils.isNumeric(n)).length !== props.maxLength || props.network.isOffline) {
	return;
	}
	// Blurs the input and removes focus from the last input and, if it should submit
	// on complete, it will call the onFulfill callback.
	blurMagicCodeInput();
	props.onFulfill(props.value);
	};

  const validateAndSubmit = () => {
        const numbers = decomposeString(props.value, props.maxLength);
        if (!firstSubmit || !props.shouldSubmitOnComplete || _.filter(numbers, (n) => ValidationUtils.isNumeric(n)).length !== props.maxLength || props.network.isOffline) {
            return;
        }
        setFirstSubmit(false)
        // Blurs the input and removes focus from the last input and, if it should submit
        // on complete, it will call the onFulfill callback.
        blurMagicCodeInput();
        props.onFulfill(props.value);
    }

What alternative solutions did you explore? (Optional)

N/A