[HOLD for payment 2023-10-13] [$500] Web - The input is lost focus on pressing enter key after no result found

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to Settings > Workspaces
2. Select any workspace and open member page
3. Click on the invite button
4. Enter the random input that will display no result found
5. Press the enter key

Expected Result:

The text input shouldn't lose focus

Actual Result:

The text input loses focus

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.73.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screencast.from.21-09-2023.16_54_44.webm

Recording.4719.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dukenv0307
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695290112584589

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a6ef58dc2b8b4afd
• Upwork Job ID: 1705612299507138560
• Last Price Increase: 2023-09-23
• Automatic offers:
• 0xmiroslav | Reviewer | 2697650
• dukenv0307 | Contributor | 26976506
• dukenv0307 | Reporter | 26976507

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a6ef58dc2b8b4afd

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @sonialiap (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[kbecciv]

Proposal by: @dukenv0307
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695290112584589

Proposal

Please re-state the problem that we are trying to solve in this issue.

The input is lost focus on pressing enter key after no result found

What is the root cause of that problem?

We have the behavior of not losing focus if no options found in some pages due to this logic in BaseOptionsSelector, so it's clear that it's intentional.
There're 2 problems:

• In screens that use the new SelectionList, we don't have that same blurOnSubmit logic. See here. There must be because the SelectionList is functionally similar to the OptionsSelector
• In EmojiPicker, we also have search functionality but doesn't have the blurOnSubmit logic

What changes do you think we should make in order to solve the problem?

• In BaseSelectionList, add

blurOnSubmit={Boolean(flattenedSections.allOptions.length)}

(this is similar logic to the BaseOptionsSelector)

• In EmojiPickerMenu, add

blurOnSubmit={this.state.searchTerm.length > 0 && this.state.filteredEmojis.length > 0}

(the searchTerm needs to be set to the state in onChangeText)

What alternative solutions did you explore? (Optional)

Any other search input that has the issue can be fixed similarly.

[JawadSadiq01]

Proposal

Please re-state the problem that we are trying to solve in this issue.
The input is lost focus on pressing enter key after no result found

What is the root cause of that problem?
Inside the reusable component filename "BaseSelectionList", there is a TextInput. The TextInput is calling a function "selectFocusedOption".

The definition of the selectFocusedOption function has below code that is causing the lost of focus on pressing enter.

 const selectFocusedOption = () => {
        const focusedOption = flattenedSections.allOptions[focusedIndex];

         if (!focusedOption || focusedOption.isDisabled) {
             // return;
        }

        selectRow(focusedOption, focusedIndex);
    };

If I remove or comment the return inside of if block code, then the TextInput won't loose its focus. In the case of the selectFocusedOption() function, all of the code that follows the return statement will not be executed. this means that the code that keeps the input field focused (the event.target.focus() call) will never be executed.

To fix this, you can simply remove or comment the return statement (BaseSelectionList.js#197) from the selectFocusedOption() function.

What alternative solutions did you explore? (Optional)
NA

See img