[HOLD for payment 2023-11-09] [HOLD #16935] [$500] Web - Clicking the back button brings back the workspace settings panel

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open a new account on ND
2. Click on FAB > New workspace
3. Click on members > invite
4. Click outside the panel to close it
5. Click on the browser back button

Expected Result:

The side panel should not open when clicking back, instead app should load the previous chat page. This behavior is not repeatable unless it is a new account.

Actual Result:

App opens up the side panel when clicking back.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.73.0
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

2023-09-22.18.37.48.mp4

Recording.4743.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Nathan-Mulugeta
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695397220000719

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ebbc655dc38b6b99
• Upwork Job ID: 1706019315934507008
• Last Price Increase: 2023-09-24
• Automatic offers:
• fedirjh | Reviewer | 26971957
• DylanDylann | Contributor | 26971960
• Nathan-Mulugeta | Reporter | 26971961

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ebbc655dc38b6b99

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[husnaink93]

Hi,
I have read your issue on Github and am going to share my proposed solution here.

Proposed Solutions:

Back Button Handling:
To mitigate the issue of the side panel appearing when users press the back button, it is imperative to manage the back button event within our application's source code. This necessitates the customization of the event handling mechanism. For Android, this customization is achievable by modifying the behavior encapsulated within the onBackPressed() method, while iOS would require the management of the UINavigationController.

State Management:
A comprehensive review of our application's state management is advisable. By monitoring the state of the side panel and implementing appropriate code, we can ensure that the panel is promptly closed when users engage the back button. Should our application utilize state management libraries such as Redux (in the case of React Native) or Provider (for Flutter), these resources can facilitate the implementation process.

Conditional Rendering:
The side panel's display can be adjusted through conditional rendering. This entails rendering the panel only under circumstances where its presence is warranted, ensuring that it remains hidden when users navigate via the back button or during specific user interactions.

Testing and Debugging:
Rigorous testing of our application is imperative, particularly in scenarios involving back button interactions. The utilization of debugging tools such as Android Studio or Xcode will aid in pinpointing the root cause of the issue and implementing effective solutions.

Regards
Husnain Khalid

[melvin-bot]

📣 @husnaink93! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>