[HOLD for payment 2023-11-02] [$500] Web - Room - Search list can be opened with CMD + K in public room as anonymous user

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to a public room as an anonymous user like https://staging.new.expensify.com/r/6874216302070473
2. Click on the search icon.
3. Close the login menu.
4. Use the shortcut CMD + K.

Expected Result:

Login menu will open when using the shortcut CMD + K, just like when clicking on the search icon in Step 2.

Actual Result:

The search list is opened when using CMD + K.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.74-2

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6214634_20230926_023604.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause-Internal Team

Slack conversation: @

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e7ac225db079b27f
• Upwork Job ID: 1706839068229685248
• Last Price Increase: 2023-10-04
• Automatic offers:
• 0xmiroslav | Reviewer | 27126702
• kushu7 | Contributor | 27126704

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kushu7]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Fixing redirect issue with using shortcut CMD + K or CMD + SHIFT + K in public room as anonymous user

What is the root cause of that problem?

The problem is we are not checking if user is anonymous or not. we are just redirecting it to search page or chat page.

App/src/libs/Navigation/AppNavigator/AuthScreens.js

Lines 182 to 191 in 3402597

	this.unsubscribeSearchShortcut = KeyboardShortcut.subscribe(
	searchShortcutConfig.shortcutKey,
	() => {
	Modal.close(() => {
	if (Navigation.isActiveRoute(ROUTES.SEARCH)) {
	return;
	}
	return Navigation.navigate(ROUTES.SEARCH);
	});
	},

unlike we are checking on Search icon click here

App/src/pages/home/sidebar/SidebarLinks.js

Line 173 in 3402597

onPress={Session.checkIfActionIsAllowed(this.showSearchPage)}

What changes do you think we should make in order to solve the problem?

We should also check this condition on shortcut click. we can update this function to like we are checking on search icon click.

Modal.close(Session.checkIfActionIsAllowed(() => {
    if (Navigation.isActiveRoute(ROUTES.SEARCH)) {
        return;
    }
    return Navigation.navigate(ROUTES.SEARCH);
}));

and we should update this chat shortcut listener also to respect anonymous users.

and we should add early return condition here to avoid re-navigating to sign-in modal page.

if (Navigation.isActiveRoute(ROUTES.SIGN_IN_MODAL)) {
    return
};

Result

Screen.Recording.2023-09-26.at.5.50.52.PM.mov

What alternative solutions did you explore? (Optional)

We can disable shortcut for anonymous users

[zanyrenney]

adding external.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e7ac225db079b27f

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Anonymous user can access new chat page

What is the root cause of that problem?

• Currently, when pressing "Ctrl + K" without login, we still allow the user to open the search modal

  App/src/libs/Navigation/AppNavigator/AuthScreens.js

  Lines 167 to 180 in 7d1f5c6

  	this.unsubscribeSearchShortcut = KeyboardShortcut.subscribe(
  	searchShortcutConfig.shortcutKey,
  	() => {
  	Modal.close(() => {
  	if (Navigation.isActiveRoute(ROUTES.SEARCH)) {
  	return;
  	}
  	return Navigation.navigate(ROUTES.SEARCH);
  	});
  	},
  	searchShortcutConfig.descriptionKey,
  	searchShortcutConfig.modifiers,
  	true,
  	);

What changes do you think we should make in order to solve the problem?

• When user pressing "Ctrl + K", we need to redirect user to login modal like below:

this.unsubscribeSearchShortcut = KeyboardShortcut.subscribe(
            searchShortcutConfig.shortcutKey,
            () => {
                interceptAnonymousUser(() => {
                    Modal.close(() => {
                        if (Navigation.isActiveRoute(ROUTES.SEARCH)) {
                            return;
                        }
                        return Navigation.navigate(ROUTES.SEARCH);
                    });
                });
            },
            searchShortcutConfig.descriptionKey,
            searchShortcutConfig.modifiers,
            true,
        );

• The interceptAnonymousUser function has been used in other sections in our source code, used to check if the user is an anonymous user:

const isAnonymousUser = Session.isAnonymousUser();
const interceptAnonymousUser = (callback) => {
    if (isAnonymousUser) {
        Session.signOutAndRedirectToSignIn();
    } else {
        callback();
    }
};

What alternative solutions did you explore? (Optional)

• We can also disable the event listener when pressing "Ctrl + K" without login like:

 if (!Session.isAnonymousUser()) {
            this.unsubscribeSearchShortcut = KeyboardShortcut.subscribe(
                // Handle event logic
            );
        }

Result:

Solution 1:

Screencast.from.29-08-2023.17.31.39.webm