[HOLD for payment 2023-10-24] [$500] Workspace - Admin Checkbox in Members Section Ticked When Changing Contact Method

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to Settings > Profile > Contact Method > Add New Contact Method
2. Go to Settings > Create Workspace > Members > Invite Members
3. Go to Settings > Profile > Contact Method > Change Contact Method
4. Go to Settings > Workspace > Members > Tick on the Select All checkboxes and observe that the Admin checkbox is also selected

Expected Result:

Changing the contact method should not cause the Admin checkbox to be ticked in the Members section.

Actual Result:

Changing the contact method causes the Admin checkbox to be ticked in the Members section.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.73.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recorder_30092023_183937.mp4

Recorder_30092023_161410.mp4

Recorder_30092023_085849.mp4

Screen.Recording.2023-09-29.at.10.38.26.PM.mov

Recording.1631.mp4

screen-capture.-.2023-09-22T140546.004.webm

screen-capture.5.mp4

Expensify/Expensify Issue URL:
Issue reported by: @tewodrosGirmaA
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695415622144909

View all open jobs on GitHub

[esh-g]

Proposal

Please re-state the issue

Able to select the policy owner after changing the contact method.

What is the root cause of this issue?

While checking whether an option should be disabled, we are setting the isDisabled property to true here:

App/src/pages/workspace/WorkspaceMembersPage.js

Line 317 in 4ea4a55

isDisabled: accountID === props.session.accountID || details.login === props.policy.owner || policyMember.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE,

But the accountID from props.policyMembers is actually a string while the props.session.accountID is actually a Number.

What changes do you think should be made to fix this problem?

We should convert the accountID from props.policyMembers to Number before comparing like we do in many other places for accountID.

isDisabled: Number(accountID) === props.session.accountID || details.login === props.policy.owner || policyMember.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE,

What other alternative options did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ccfbef1a9c9e1edd

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace - Admin Checkbox in Members Section Ticked When Changing Contact Method

What is the root cause of that problem?

When we change the contact method, policy.onwer is not updated until the openApp API is called again so details.login === props.policy.owner is false. Additional, props.session.accountID is string and accountID is number that makes accountID === props.session.accountID is always false

App/src/pages/workspace/WorkspaceMembersPage.js

Line 317 in 52f0e3c

isDisabled: accountID === props.session.accountID || details.login === props.policy.owner || policyMember.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE,

What changes do you think we should make in order to solve the problem?

Instead of compare accountID === props.session.accountID we can re-use isAdmin or use props.session.email === details.login

App/src/pages/workspace/WorkspaceMembersPage.js

Line 311 in 52f0e3c

const isAdmin = props.session.email === details.login || policyMember.role === CONST.POLICY.ROLE.ADMIN;

App/src/pages/workspace/WorkspaceMembersPage.js

Line 317 in 52f0e3c

isDisabled: accountID === props.session.accountID || details.login === props.policy.owner || policyMember.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE,

What alternative solutions did you explore? (Optional)

In setContactMethodAsDefault function we can update policy.onwer of all policies of current user to new contact method in optimisticData and reset it in failureData

[alexpensify]

@parasharrajat - when you get a chance can you review if one of these proposals will resolve this issue? Thanks!