[HOLD for payment 2023-10-25] [$500] Chat - App closes mention suggestions when cursor is between double @

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Action Performed:

1. Open the app
2. Open any report
3. Write @, it will trigger mention suggestions
4. Write any letter, number or symbol after it
5. Take it cursor back to position after the @ and observe that app again displays mention suggestions
6. Clear everything and write double @@
7. Take cursor back to position after the first @ and observe that app does not display mention suggestions

Expected Result:

App should display mention suggestions according to cursor position and text before it

Actual Result:

App does not display mention suggestions even though @ is present before cursor if @ is also present after cursor

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.77.2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

android.native.double.@.mention.issue.mp4

android.chrome.double.@.mention.issue.mp4

windows.chrome.double.@.mention.issue.mp4

ios.native.safari.double.@.mention.issue.mov

mac.chrome.double.@.mention.issue.mov

mac.desktop.double.@.mention.issue.mov

Recording.4843.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696338120628179

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017e08f14329a2fd98
• Upwork Job ID: 1709321185861791744
• Last Price Increase: 2023-10-10
• Automatic offers:
• paultsimura | Contributor | 27123369
• dhanashree-sawant | Reporter | 27123379

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017e08f14329a2fd98

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[paultsimura]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Placing a cursor in between consecutive @ signs doesn't show the name suggestions.

What is the root cause of that problem?

We are using a RegExp that no longer exists (CONST.REGEX.NEW_LINE_OR_WHITE_SPACE_OR_EMOJI) to calculate the end of the next word after the cursor:

App/src/pages/home/report/ReportActionCompose/SuggestionMention.js

Line 191 in a4f4a77

const indexOfFirstWhitespaceCharOrEmojiAfterTheCursor = valueAfterTheCursor.search(CONST.REGEX.NEW_LINE_OR_WHITE_SPACE_OR_EMOJI);

As a result, the value of indexOfFirstWhitespaceCharOrEmojiAfterTheCursor is always 0 (as RegExp is undefined), and the calculation logic is broken.

What changes do you think we should make in order to solve the problem?

We should replace the non-existing RegExp with the one that replaced it in #19004

-           const indexOfFirstWhitespaceCharOrEmojiAfterTheCursor = valueAfterTheCursor.search(CONST.REGEX.NEW_LINE_OR_WHITE_SPACE_OR_EMOJI);
+           const indexOfFirstWhitespaceCharOrEmojiAfterTheCursor = valueAfterTheCursor.search(CONST.REGEX.SPECIAL_CHAR_OR_EMOJI);

Result:

double-mention.mov

What alternative solutions did you explore? (Optional)

[Christinadobrzyn]

Hey team! Do you think this GH has the same root and therefore the same fix? #28753

[paultsimura]

Hey @Christinadobrzyn , even though I'm not a part of the Internal team:
#28753 is a regression from the recently merged #28045

And this issue (#28754) existed relatively long before that regression – at least since #25758.