[HOLD for payment 2023-11-07] [$500] WS - Members - List of users invited to the workspace does not scroll with Up and Down arrows

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging.new.expensify.com or open Desktop App
2. Login with Expensifail account
3. Create new or go to existing workspace
4. Go to Workspace > Members
5. Click Invite
6. Scroll user list with Up and Down Arrows on keyboard

Expected Result:

The user list is scrolled with Up and Down arrows

Actual Result:

The userlist does not scroll with Up and Down arrows

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome
• Windows / Chrome

Version Number: 1.3.79-3

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6227828_1696612682443.Desktop-User-list-not-scroll.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d02644145db5dadc
• Upwork Job ID: 1711429026906808320
• Last Price Increase: 2023-10-16
• Automatic offers:
• jayeshmangwani | Contributor | 27251251

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[jayeshmangwani]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Scroll is not happeing on Invite new members page, when we use the up and down key from keyboard

What is the root cause of that problem?

We are using BaseSelectionList Component to display the members on the Invite page,

On BaseSelectionList page we have created a useCallback function scrollToIndex that is responsible for scrolling of the list

App/src/components/SelectionList/BaseSelectionList.js

Lines 155 to 156 in 6682740

	const scrollToIndex = useCallback((index, animated = true) => {
	const item = flattenedSections.allOptions[index];

2nd line of this function access the flattenedSections.allOptions, that is used for getting the value of the item,

const item = flattenedSections.allOptions[index];

So issue is happening because , initially allOptions will be empty array and when we have allOptions is empty then item will be null/undefined ,

App/src/components/SelectionList/BaseSelectionList.js

Lines 79 to 80 in 6682740

	const flattenedSections = useMemo(() => {
	const allOptions = [];

If item will null then we are returning early on scrollToIndex function thats why scrolling is not happening

App/src/components/SelectionList/BaseSelectionList.js

Lines 155 to 160 in 6682740

	const scrollToIndex = useCallback((index, animated = true) => {
	const item = flattenedSections.allOptions[index];
	if (!listRef.current || !item) {
	return;
	}

What changes do you think we should make in order to solve the problem?

Initially flattenedSections.allOptions will be empty but when memoized will be complete then we will have the allOptions array, so I would suggest that we should pass the to flattenedSections.allOptions dependency to scrollToIndex useCallback function

App/src/components/SelectionList/BaseSelectionList.js

Lines 176 to 179 in 6682740

	// If we don't disable dependencies here, we would need to make sure that the `sections` prop is stable in every usage of this component.
	// eslint-disable-next-line react-hooks/exhaustive-deps
	}, []);

[flattenedSections.allOptions]

Result

result.mov

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[shmaxey]

Isa is OOO for a few days, can you please carry forward for her? Thanks!