[HOLD for payment 2024-02-26] [$500] App does not focus to first option on search if selected from first page option in timezone

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open settings->profile->timezone
3. Open timezone and scroll to top
4. Select any one timezone from the visible timezones when scrolled to top eg: Africa/Asmara
5. Search any term in search (eg: IN) and observe that focus is not changed to first value as it normally does for all other similar UI

Expected Result:

App should shift focus to first option on search in timezone

Actual Result:

After scroll to top and selecting any one timezone from visible options, app does not shift focus to first option on search in timezone

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.79.3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

android.native.timezone.position.error.mov

Recording.4895.mp4

mac.chrome.desktop.timezone.maintains.search.position.1.mov

ios.safari.native.timezone.maintains.search.position.1.mov

windows.chrome.timezone.focus.not.shift.to.first.1.mp4

android.chrome.timezone.maintains.search.position.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696672477964269

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0178208b9c15b89907
• Upwork Job ID: 1711342124473376768
• Last Price Increase: 2023-10-16
• Automatic offers:
• abzokhattab | Contributor | 27368232
• dhanashree-sawant | Reporter | 27368237

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0178208b9c15b89907

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[abzokhattab]

Proposal

Please re-state the problem that we are trying to solve in this issue.

SelectionList does not change the focus to first option when the options list changes

What is the root cause of that problem?

This issue occurs because we dont change the focus to the first item when the sections list changes in the SelectionList component in this file

https://github.com/Expensify/App/blob/df377f22e5820e6e524b065360e186f77a8e9625/src/components/SelectionList/BaseSelectionList.js

What changes do you think we should make in order to solve the problem?

To change the focus on the first item whenever the sections list changes , we need to add the following useEffect that updates the focusIndex to zero whenever the section changes

    useEffect(() => {
        //do not change focus on the first render, as it should focus on the selected item
        if (firstLayoutRef.current) {
            return;
        }

        // set the focus on the first item when the sections list is changed
        if (sections.length > 0) {
            updateAndScrollToFocusedIndex(0);
        }
    }, [sections]);

Alternative Solution:

Change SelectionList to OptionsSelector like we are doing in the iou/currency selection compoenent

so we should add this

<OptionsSelector
  headerMessage={
    timezoneInputText.trim() && !timezoneOptions.length
      ? translate("common.noResultsFound")
      : ""
  }
  textInputLabel={translate("timezonePage.timezone")}
  value={timezoneInputText}
  onChangeText={filterShownTimezones}
  onSelectRow={saveSelectedTimezone}
  sections={[
    { data: timezoneOptions, indexOffset: 0, isDisabled: timezone.automatic },
  ]}
  initiallyFocusedOptionKey={_.get(
    _.filter(timezoneOptions, (tz) => tz.text === timezone.selected)[0],
    "keyForList"
  )}
  showScrollIndicator
/>

and also import the greencheck:

const greenCheckmark = {
  src: Expensicons.Checkmark,
  color: themeColors.success,
};

and use it in the allTimeZones var:

const allTimezones = useRef(
  _.chain(TIMEZONES)
    .filter((tz) => !tz.startsWith("Etc/GMT"))
    .map((text) => ({
      text,
      customIcon: text === timezone.selected ? greenCheckmark : undefined,
      keyForList: getKey(text),
      isSelected: text === timezone.selected,
    }))
    .value()
);

POC:

Screen.Recording.2023-10-08.at.2.31.41.AM.mov

Screen.Recording.2023-10-20.at.2.10.21.AM.mov

[Santhosh-Sellavel]

@jliexpensify Can you reassign a new C+ by applying external label again? Unassigning this one due to low bandwidth