[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] Chat - App crash when open edit date request money by deep link

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.80.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @namhihi237
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696863974272199

Action Performed:

1. Create a request money
2. Click request preview
3. Click request item
4. Click date and copy url
5. Create a public room and send URL
6. Logout and open the publish room
7. Click open url

Expected Result:

App does not crash

Actual Result:

App crash when open edit date request money by deep link

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen.Recording.2023-10-09.at.22.36.55.1.mov

iOS: Native

iOS: mWeb Safari

Screen.Recording.2023-10-09.at.22.49.25.mov

MacOS: Chrome / Safari

Screen.Recording.2023-10-09.at.22.06.44.mov

MacOS: Desktop

Screen.Recording.2023-10-09.at.22.26.22.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c4f5d983bc3511a7
• Upwork Job ID: 1711819993131061248
• Last Price Increase: 2023-10-10

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @puneetlath (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[namhihi237]

This issue come from #28645

[puneetlath]

@tgolen mind taking a look? Seems to be coming from your PR.

[saranshbalyan-1234]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crash when open edit date request money by deep link

What is the root cause of that problem?

While page is being accessed via deep link, initially report object is null which gives this error as we cannot access properties of null or undefined here

App/src/pages/EditRequestPage.js

Lines 323 to 326 in b2cbd26

	key: ({report, parentReportActions}) => {
	const parentReportAction = lodashGet(parentReportActions, [report.parentReportActionID]);
	return `${ONYXKEYS.COLLECTION.TRANSACTION}${lodashGet(parentReportAction, 'originalMessage.IOUTransactionID', 0)}`;
	},

What changes do you think we should make in order to solve the problem?

use report object like we use in other places of same component like this

App/src/pages/EditRequestPage.js

Line 316 in b2cbd26

key: ({report}) => `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${report ? report.parentReportID : '0'}`,

thus the solution would look something like this

 const parentReportAction = lodashGet(parentReportActions, [report ? report.parentReportActionID : '0']);

What alternative solutions did you explore? (Optional)

N/A

[tgolen]

@saranshbalyan-1234 Has the correct solution 👍

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c4f5d983bc3511a7