[HOLD for payment 2023-11-06] [HOLD for payment 2023-11-02] [$500] Login - Email address does not remain when refresh Magic Code page and hit Go back button

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.80-0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

1. Navigate to staging.new.expensify.com
2. Enter e-mail address & click Sign in button
3. Refresh the page
4. Hit Go back button

Expected Result:

Once added, e-mail address should remain after refreshing Magic Code page and hit Go back button

Actual Result:

Email address does not remain when refresh Magic Code page and hit Go back button

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• Windows: Chrome
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

Windows: Chrome

Bug6231886_1696943447632.Recording__1224.mp4

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0181306db2b58c51f7
• Upwork Job ID: 1714251654275936256
• Last Price Increase: 2023-10-17
• Automatic offers:
• fedirjh | Reviewer | 27339710
• bernhardoj | Contributor | 27339711

Issue Owner

Current Issue Owner: @zanyrenney

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The login input is removed when we refresh the web app while we are on the magic code input form.

What is the root cause of that problem?

The login input value is just a simple state which means if we refresh the web, the value is cleared.

App/src/pages/signin/LoginForm/BaseLoginForm.js

Line 88 in 518161c

const [login, setLogin] = useState('');

However, when we refresh the web while we are on the magic code input form, I expect that going back to the login form would show the login I submitted before.

What changes do you think we should make in order to solve the problem?

When we submit the login, it will be saved to CREDENTIALS onyx. We can use this onyx to set the initial value of the login state. (we also use this to show the login before the "Go back" button)

const [login, setLogin] = useState(() => {
    const userLogin = Str.removeSMSDomain(props.credentials.login || '');
    return userLogin;
});

[melvin-bot]

@sonialiap Eep! 4 days overdue now. Issues have feelings too...

[sonialiap]

Reproducible

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0181306db2b58c51f7