[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] DEV : App crash when visiting Task's settings for the first time

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: dev only
Reproducible in staging?: only in dev
Reproducible in production?: only in dev
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696933959561659

Action Performed:

1. Go to any report.
2. Create a new task.
3. Click on task header => Choose Settings.
4. Notice app is crashed.

Expected Result:

App shouldn't be crashed while opening setting of Task

Actual Result:

App crash when visiting Task's settings for the first time

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2023-10-10.at.17.34.03.mov

Screen.Recording.2023-10-10.at.17.32.46.mov

MacOS: Desktop

Screen.Recording.2023-10-10.at.17.33.30.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01dbd96ea5f53ec4b8
• Upwork Job ID: 1712137881041838080
• Last Price Increase: 2023-10-11
• Automatic offers:
• s77rt | Reviewer | 27145434
• hungvu193 | Contributor | 27145438
• hungvu193 | Reporter | 27145441

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01dbd96ea5f53ec4b8

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[hungvu193]

Post the proposal where I'm the reporter

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crash when visiting Task's settings for the first time (after few reloads it will work).

What is the root cause of that problem?

We're now displaying the Settings option for our Task detail, however after creating our Task report object didn't have the property notificationPreference. Later when we accessed it here it will crash because we didn't have value for it:

App/src/pages/settings/Report/ReportSettingsPage.js

Lines 69 to 72 in a63f853

	const notificationPreference =
	report.notificationPreference !== CONST.REPORT.NOTIFICATION_PREFERENCE.HIDDEN
	? translate(`notificationPreferencesPage.notificationPreferences.${report.notificationPreference}`)
	: '';

What changes do you think we should make in order to solve the problem?

We should add the notificationPreference: CONST.REPORT.NOTIFICATION_PREFERENCE.ALWAYS, default value while creating a new task by adding it here:

App/src/libs/ReportUtils.js

Line 2821 in a63f853

parentReportID,

What alternative solutions did you explore? (Optional)

We should disable Settings option for Task report.

[Pujan92]

Seems regression from #28200 where we get rid of shouldDisableSettings which will show the settings for all report types. cc: @techievivek

[techievivek]

however after creating our Task report object didn't have the property notificationPreference. Later when we accessed it here it will crash because we didn't have value for it:

Can we add immediately as the value for the notification preference in the optimistic data for newly created task/group chats or any report?

[techievivek]

I see you have already added that, great.