Skip to content

[PAY 8/19] Fix how validation displays in UI #2934

@Beamanator

Description

@Beamanator

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Expected Result:

Front-end validation should catch obviously invalid phone numbers, and display the error message "Please enter a phone number including the country code e.g +447814266907" instead of a clickable OptionRow. Like this:

Screen Shot 2021-05-14 at 8 52 39 PM

Actual Result:

No visual feedback given to user when OptionRow with invalid phone number is clicked, only an error is shown in the console:

Screen Shot 2021-05-14 at 8 49 09 PM

Action Performed:

  1. Click search icon
  2. Enter an invalid phone number (example: 7777)
  3. Click on the OptionRow that shows up:

Screen Shot 2021-05-14 at 8 47 49 PM

Workaround:

No workaround (other than making sure you enter valid phone numbers), but not a deploy-blocking issue.

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.0.46.0
Notes/Photos/Videos:
Enhancements that can we worked on concurrently by the assigned engineer of this issue or worked on a week after this closes by someone else #2936

Expensify/Expensify Issue URL: https://github.com/Expensify/Expensify/issues/159892

View all open jobs on Upwork

Metadata

Metadata

Labels

EngineeringExternalAdded to denote the issue can be worked on by a contributorImprovementItem broken or needs improvement.WeeklyKSv2

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions