[HOLD for payment 2023-10-25] [$500] Fab - App disables CTRL+K / CTRL+SHIFT+K shortcuts on FAB menu option pages

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.81.5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697011802723769

Action Performed:

1. Open the app
2. Click on green plus and click on any FAB menu option eg: 'save the world'
3. Click 'CTRL+K' or 'CTRL+SHIFT+K' and observe that it does not work

Expected Result:

App should not disable CTRL+K / CTRL+SHIFT+K shortcuts

Actual Result:

App disables CTRL+K / CTRL+SHIFT+K shortcuts on FAB menu option pages

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

mac.chrome.ctrl.k.not.working.save.the.world.mov

windows.chrome.ctrl.k.not.working.save.the.world.mp4

Recording.4952.mp4

MacOS: Desktop

mac.desktop.ctrl.k.not.working.save.the.world.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015979bf65c1172e21
• Upwork Job ID: 1712146924604538880
• Last Price Increase: 2023-10-11

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~015979bf65c1172e21

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

[pradeepmdk]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App disables CTRL+K / CTRL+SHIFT+K shortcuts on FAB menu option pages

What is the root cause of that problem?

when popovermenu open we are setting closemodal but we never cleaned

App/src/components/PopoverWithoutOverlay/index.js

Line 48 in b820046

Modal.setCloseModal(props.isVisible ? () => props.onClose(props.anchorRef) : null);

so here when close modal is present its doesn't onModalCloseCallback trigger

App/src/libs/actions/Modal.ts

Line 17 in b820046

function close(onModalCloseCallback: () => void, isNavigating = true) {

What changes do you think we should make in order to solve the problem?

App/src/components/PopoverWithoutOverlay/index.js

Line 48 in b820046

Modal.setCloseModal(props.isVisible ? () => props.onClose(props.anchorRef) : null);

here on cleanup function we should clear the modal

 Modal.setCloseModal(props.isVisible ? () => props.onClose(props.anchorRef) : null);

        return () => {
            Modal.setCloseModal(null)
        }
        // We want this effect to run strictly ONLY when isVisible prop changes
        // eslint-disable-next-line react-hooks/exhaustive-deps
    }, [props.isVisible]);

What alternative solutions did you explore? (Optional)

App/src/components/PopoverMenu/index.js

Line 81 in f557852

if (selectedItemIndex.current !== null) {

here when once popover menu selected we should clear the modal
Modal.setCloseModal(null)

[maxconnectAbhi]

Proposal

Please re-state the problem that we are trying to solve in this issue

Fab - App disables CTRL+K / CTRL+SHIFT+K shortcuts on FAB menu

What is the root cause of that problem?

Certainly! It seems that using the keyboard shortcuts CTRL+K or CTRL+SHIFT+K should open a search modal. However, if you've already opened a modal using the FAB menu, these shortcuts won't trigger the search modal again.

https://github.com/Expensify/App/blob/f5578523a10653b03de827e38f99f3ba54241a69/src/libs/Navigation/AppNavigator/AuthScreens.js#L185C8-L198C11

        this.unsubscribeSearchShortcut = KeyboardShortcut.subscribe(
            searchShortcutConfig.shortcutKey,
            () => {
                Modal.close(() => {
                    if (Navigation.isActiveRoute(ROUTES.SEARCH)) {
                        return;
                    }
                    return Navigation.navigate(ROUTES.SEARCH);
                });
            },
            searchShortcutConfig.descriptionKey,
            searchShortcutConfig.modifiers,
            true,
        );

What changes do you think we should make in order to solve the problem?

To ensure the CTRL+K or CTRL+SHIFT+K shortcuts activate the search modal, make sure to close any currently open modals beforehand through Modal.setCloseModal() function.

this.unsubscribeSearchShortcut = KeyboardShortcut.subscribe(
            searchShortcutConfig.shortcutKey,
            () => {
             if (!Navigation.isActiveRoute(ROUTES.SEARCH)) {
                    Modal.setCloseModal()
                  }
                Modal.close(() => {
                    if (Navigation.isActiveRoute(ROUTES.SEARCH)) {
                        return;
                    }
                    return Navigation.navigate(ROUTES.SEARCH);
                });
            },
            searchShortcutConfig.descriptionKey,
            searchShortcutConfig.modifiers,
            true,
        );
      

result

Clip.mov

What alternative solutions did you explore? (Optional)

NA

[ishpaul777]

regression from #29251 confirmed by reverting changes from PR

[astrohunter62]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App disables CTRL+K / CTRL+SHIFT+K shortcuts after the modal is closed.

What is the root cause of that problem?

App/src/components/PopoverWithoutOverlay/index.js

Lines 42 to 46 in 64d3e39

	// We prevent setting closeModal function to null when the component is invisible the first time it is rendered
	if (!firstRenderRef.current || !props.isVisible) {
	firstRenderRef.current = false;
	return;
	}

The purpose of this code block is to prevent setting closeModal function to null when the component is invisible the first time it is rendered.
It's not correctly working because !firstRenderRef.current.

What changes do you think we should make in order to solve the problem?

 if (firstRenderRef.current || !props.isVisible) { 
     firstRenderRef.current = false; 
     return; 
 } 

Results:

29341.webm