[HOLD for payment 2023-11-09] [$500] Skeleton loader no longer has gradient animation

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.83-5
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697130116067009

Action Performed:

Open up the app and wait for your chats list and chat content to load

Expected Result:

The skeleton loader that acts as the placeholder while content loads should have a subtle gradient animation

Actual Result:

There is no animation

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c95171227c9c77b5
• Upwork Job ID: 1712587975218712576
• Last Price Increase: 2023-10-19

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c95171227c9c77b5

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Skeleton loader no longer has gradient animation

What is the root cause of that problem?

We're importing SkeletonViewContentLoader from react-content-loader/native instead of react-content-loader which caused the issue.
I think the recent changes broke the webpack config of react-content-loader.

What changes do you think we should make in order to solve the problem?

We should change the current webpack config of react-content-loader to:

'react-content-loader/native': path.resolve(__dirname, '../../node_modules/react-content-loader'),

What alternative solutions did you explore? (Optional)

We should create SkeletonViewContentLoader/index.native.js and SkeletonViewContentLoader/index.js where in index.native.js we will import SkeletonViewContentLoader from react-content-loader/native and inside SkeletonViewContentLoader/index.js we will import SkeletonViewContentLoader from react-content-loader.

After that update the import usage of SkeletonViewContentLoader to use our file instead of using directly from the react-content-loader.

Result:

Screen.Recording.2023-10-13.at.09.53.19.mov

[shawnborton]

Nice! Do you have any idea how this bug got introduced in the first place?

[melvin-bot]

@lschurr, @thesahindia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!