[HOLD for payment 2023-11-13] [$500] Room - Message starting with “<<“ not displayed in the welcome message

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.84.0
Reproducible in staging?: y
Reproducible in production?: new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697214320531079

Action Performed:

1. Navigate to Send message > Room
2. Enter a room name and enter a welcome message starting with “<<message”
3. Select a workspace and create the room
4. Go to the room detail page > Settings > Welcome message

Expected Result:

Message starting with “<<“ should be displayed in the welcome message

Actual Result:

Message starting with “<<“ not showing in the welcome message

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

crashed, not able to check

Android: mWeb Chrome

Screen_Recording_20231014_115905_Chrome.mp4

iOS: Native

Screen.Recording.2023-10-13.at.9.26.29.PM.mov

iOS: mWeb Safari

Screen.Recording.2023-10-13.at.9.32.01.PM.mov

MacOS: Chrome / Safari

2023-10-13.20-59-57.mp4

MacOS: Desktop

Screen.Recording.2023-10-13.at.11.38.01.PM.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01aaeb78bffb57b09f
• Upwork Job ID: 1713225046807224320
• Last Price Increase: 2023-10-28
• Automatic offers:
• cubuspl42 | Reviewer | 27443023
• abzokhattab | Contributor | 27443025

[melvin-bot]

Triggered auto assignment to @peterdbarkerUK (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01aaeb78bffb57b09f

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

[abzokhattab]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Message starting with “<<“ is not shown in the welcome message

What is the root cause of that problem?

The frontend displays the welcome message by converting it from html to markdown and the problem arises when creating a new room, special markdown characters, such as < in the welcome message field are not correctly escaped. This results in the frontend displaying an empty quotation.

What changes do you think we should make in order to solve the problem?

in the create action we should parse the message before it is saved, like we do in the update wlcome message action

App/src/libs/actions/Report.js

Line 1355 in eabe4f4

const parsedWelcomeMessage = ReportUtils.getParsedComment(newValue);

To parse the message when creating the room:

we need to add the prev line in the addPolicyReport function as well this way the create and update welcome message actions have the same same parsing process which ensures consistency.

const parsedWelcomeMessage = ReportUtils.getParsedComment(welcomeMessage);

and use it here:

const policyReport = ReportUtils.buildOptimisticChatReport(
  participants,
  reportName,
  CONST.REPORT.CHAT_TYPE.POLICY_ROOM,
  policyID,
  CONST.REPORT.OWNER_ACCOUNT_ID_FAKE,
  false,
  "",
  visibility,
  writeCapability,

  // The room might contain all policy members so notifying always should be opt-in only.
  CONST.REPORT.NOTIFICATION_PREFERENCE.DAILY,
  "",
  "",
  parsedWelcomeMessage
);

and finally in the api.write:

API.write(
  "AddWorkspaceRoom",
  {
    policyID: policyReport.policyID,
    reportName,
    visibility,
    reportID: policyReport.reportID,
    createdReportActionID: createdReportAction.reportActionID,
    writeCapability,
    welcomeMessage: parsedWelcomeMessage
  },
  { optimisticData, successData, failureData }
);

POC

Screen.Recording.2023-10-14.at.7.42.19.PM.mov

[AmjedNazzal]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Room - Message starting with “<<“ not displayed in the welcome message

What is the root cause of that problem?

The reason for this is that we are parsing the welcome message using htmlToMarkdown which doesn't accept "<>"

App/src/pages/ReportWelcomeMessagePage.js

Line 49 in fe282b4

const [welcomeMessage, setWelcomeMessage] = useState(parser.htmlToMarkdown(props.report.welcomeMessage));

What changes do you think we should make in order to solve the problem?

Instead of using parser.htmlToMarkdown we can use parser.htmlToText since the welcome message is just text or we can just use report.welcomeMessage as it is

Result

Screen.Recording.2023-10-14.at.8.04.49.PM.mov