[HOLD for payment 2023-10-27] [$500] Login - Site in Spanish automatically changes to English on signing out

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.84-0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

1. Launch app
2. Scroll down and change language to Spanish
3. Tap on G and login using any account
4. Now app opens in Spanish
5. Log out

Expected Result:

Site in Spanish must remain in the same language on signing out

Actual Result:

After log out, now page is displayed in English instead of Spanish
Site in Spanish automatically changes to English on signing out

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Bug6237145_1697298474572.login.mp4

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0155ff15b3754aa4ec
• Upwork Job ID: 1713780600845426688
• Last Price Increase: 2023-10-16
• Automatic offers:
• fedirjh | Reviewer | 27222589
• tienifr | Contributor | 27222590

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[abdel-h66]

Seems like the backend is not sending the correct preferred language of the user upon the reconnect.

When api?command=OpenApp is called, it sets a bunch of values and one of them is this. Even if the preferred language is ES

{onyxMethod: "merge", key: "preferredLocale", value: "en"}

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0155ff15b3754aa4ec

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Login - Site in Spanish automatically changes to English on signing out

What is the root cause of that problem?

When users navigate to SignIn page, we always change the locale to device locale (in this case, it's english)

App/src/pages/signin/SignInPage.js

Lines 100 to 102 in 7d08e23

	useEffect(() => {
	App.setLocale(Localize.getDevicePreferredLocale());
	}, []);

What changes do you think we should make in order to solve the problem?

We should check the current preferredLocale is present or not. If not, we should update preferredLocale to the device locale. Otherwise do nothing

    useEffect(() => {
        if(preferredLocale) return 
        App.setLocale(Localize.getDevicePreferredLocale());
    }, []);

[fedirjh]

@tienifr proposal looks good to me.

🎀 👀 🎀 C+ reviewed