[HOLD for payment 2023-11-02] [$125] Member list - Tooltip show phone number include "@expensify.sms"

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.84-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @namhihi237
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697284170153569

Action Performed:

1. Create a workspace
2. Go to member and click invite
3. Input invite account phone number "eg: +84989493033"
4. Click next => Invite
5. Hover onto the newly invited member's avatar, Observe that the phone number contains "@expensify.sms""

Expected Result:

Tooltip show does not include "@expensify.sms"

Actual Result:

Tooltip show phone number include "@expensify.sms"

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2023-10-14.at.17.48.36.1.mov

MacOS: Desktop

View all open jobs on GitHub

web.1.mov

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015beae79e8b315fdb
• Upwork Job ID: 1713671640416272384
• Last Price Increase: 2023-10-23

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~015beae79e8b315fdb

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[m-natarajan]

Proposal by @namhihi237

Please re-state the problem that we are trying to solve in this issue.

The tooltip shown does not include "@expensify.sms" on the member page, it should not include '@expensify.sms'

What is the root cause of that problem?

We have the logic to get the name to show the tooltip here:

App/src/pages/workspace/WorkspaceMembersPage.js

Lines 331 to 337 in fe282b4

	icons: [
	{
	source: UserUtils.getAvatar(details.avatar, accountID),
	name: details.login,
	type: CONST.ICON_TYPE_AVATAR,
	},
	],

But we don't format if the login is a phone number because it has the format "xxxxxx@expensify.sms"
In addition, I also found the same error in TaskPreview, we previously fixed it but since we switched to using accountid here, the error has returned.

App/src/components/ReportActionItem/TaskPreview.js

Lines 79 to 82 in fe282b4

	const htmlForTaskPreview =
	taskAssignee && taskAssigneeAccountID !== 0
	? `<comment><mention-user accountid="${taskAssigneeAccountID}">@${taskAssignee}</mention-user> ${taskTitle}</comment>`
	: `<comment>${taskTitle}</comment>`;

But we haven't formatted the phone here:

App/src/components/HTMLEngineProvider/HTMLRenderers/MentionUserRenderer.js

Line 43 in fe282b4

displayNameOrLogin = lodashGet(user, 'login', '') || lodashGet(user, 'displayName', '') || translate('common.hidden');

What changes do you think we should make in order to solve the problem?

We should use formatPhoneNumber to format the name

1. In here

name: props.formatPhoneNumber(details.login),

2. And MentionUserRenderer

displayNameOrLogin = LocalePhoneNumber.formatPhoneNumber(lodashGet(user, 'login', '')) || lodashGet(user, 'displayName', '') || translate('common.hidden');

What alternative solutions did you explore? (Optional)

N/Axqx

[saad995]

Please re-state the problem that we are trying to solve in this issue.
The tooltip shows "@expensify.sms" on the member page icon, it should not include '@expensify.sms'.

What is the root cause of that problem?
For the icon tooltip, we are not formatting the login name,

What changes do you think we should make in order to solve the problem?
We can make use of the already defined function for formatting phone number, the change would look like this,

[melvin-bot]

@eVoloshchak, @miljakljajic Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!