[HOLD for payment 2024-01-03] [$125] Split Bill - Merchant must have the same value after creating the split bill

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.84.7
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @namhihi237
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697047715565069

Action Performed:

1. Click FAB button
2. Click request money
3. Enter amount => Next
4. Click split 2 users
5. Click add to split
6. Click show more => Merchant, Observe that the default value is "Request"
7. Click split
8. Click Split preview
9. Click show more, in merchant, Observe "Split with...."

Expected Result:

Merchant must have the same value after creating the split bill

Actual Result:

There is a difference between the merchant after splitting the bill, when they create the merchant the value is "Request" but when the slit bill is created the merchant has the value "Split with...."

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Screen.Recording.2023-10-12.at.16.01.35.1.mov

Android: mWeb Chrome

Screen.Recording.2023-10-12.at.15.47.34.1.mov

iOS: Native

RPReplay_Final1697100622.MP4

iOS: mWeb Safari

RPReplay_Final1697100658.MP4

MacOS: Chrome / Safari

Screen.Recording.2023-10-12.at.01.09.35.mov

Recording.5015.mp4

MacOS: Desktop

Screen.Recording.2023-10-12.at.15.49.12.mov

View all open jobs on GitHub

[melvin-bot]

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[sicarius97]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Instead of taking in the user input in the merchant field (by default "Request") in the split bill screen, it automatically defaults to "Split with [participants]".

What is the root cause of that problem?

The cause of this issue is that in this code the merchant is automatically formatted on splits to the above mentioned:

App/src/libs/actions/IOU.js

Lines 914 to 927 in a456ef9

	const splitTransaction = TransactionUtils.buildOptimisticTransaction(
	amount,
	currency,
	CONST.REPORT.SPLIT_REPORTID,
	comment,
	'',
	'',
	'',
	`${Localize.translateLocal('iou.splitBill')} ${Localize.translateLocal('common.with')} ${formattedParticipants} [${DateUtils.getDBTime().slice(0, 10)}]`,
	undefined,
	undefined,
	undefined,
	category,
	);

What changes do you think we should make in order to solve the problem?

Instead of automatically formatting it to the "Split with [participants]" by default like it is currently, line 922 above should instead take in the submitted user input when building the transaction so that it reflects that value on submission like it does for the other fields. Specifically, that line and one other just need to be changed to the input prop var merchant .

[trjExpensify]

Oh interesting, I think @youssef-lr should have solved this.

[melvin-bot]

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.