[HOLD for payment 2023-10-30] [$500] DEV: Web - Console error on login

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: Dev 1.3.86.0
Reproducible in staging?: n
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697633043348869

Action Performed:

1. Logout if you already login
2. Enter email and magic code

Expected Result:

should not show console error

Actual Result:

console error appears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2023-10-18.at.6.14.19.PM.mov

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010b8af22ad298788b
• Upwork Job ID: 1714664714880716800
• Last Price Increase: 2023-10-18
• Automatic offers:
• fedirjh | Contributor | 27263678
• gadhiyamanan | Reporter | 27263681

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010b8af22ad298788b

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[abdel-h66]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Console errors appears after login and automatic navigation to the ReportScreen.

What is the root cause of that problem?

ReportScreen is expecting the userLeavingStatus to a boolean.

                key: ({route}) => {
                    return `${ONYXKEYS.COLLECTION.REPORT_USER_IS_LEAVING_ROOM}${getReportID(route)}`
                },

• Right after the login, getReportID(route) will return an empty string.
• The empty string passed to Onyx will cause it to return the whole object, something that looks like

{
userIsLeavingRoom_some_id: false
}

• The initial value here won't be applied because the results is there. it's just not the way we want it.

What changes do you think we should make in order to solve the problem?

Add this check. We only return the value from the collection when the reportID becomes available.

            userLeavingStatus: {
                key: ({route}) => {
                    if(!getReportID(route)) {
                        return false;
                    }

                    return `${ONYXKEYS.COLLECTION.REPORT_USER_IS_LEAVING_ROOM}${getReportID(route)}`
                },
                initialValue: false,
            },

What alternative solutions did you explore? (Optional)

N/A

[Pujan92]

@5war00p @fedirjh Seems a regression from #29590 where null is replaced with an empty string here. Now it returns the collection for reportUserIsLeavingRoom_ and reportActions_ due to an empty string which earlier returns undefined by considering reportUserIsLeavingRoom_null and reportActions_null I believe.

[parasharrajat]

Correct. It is a regression from #29590.

@adelekennedy Please assign @fedirjh as C+ to handle regression. There will only be reporting payment afterwards.