Skip to content

[HOLD for payment 2023-11-09] Rename shouldDisableWriteActions to canUserPerformWriteAction #29882

@tgolen

Description

@tgolen

Problem

This code defines a method called shouldDisableWriteActions which doesn't conform to our styles for using positively named things.

This is coming from my large refactoring PR that I'm trying to break down into smaller pieces.

Why this is important

It ensures that our code consistently follows our style guide. The positive naming of this method will make it more clear what the intention is for referencing it.

Solution

Rename the method to canUserPerformWriteAction and reverse all the logic.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~015de6055d0c654f99
  • Upwork Job ID: 1714685712619388928
  • Last Price Increase: 2023-10-18
Issue OwnerCurrent Issue Owner: @laurenreidexpensify

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringInternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions