[HOLD for payment 2023-10-30] [HOLD for payment 2023-10-27] [$250] Login - App crash on login

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.87.1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan /Applause- Internal team reported later
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697694190199399

Action Performed:

1. Logout if you logged in
2. Create new account
3. Enter email which is not used before and enter magic code

Expected Result:

App should not crash

Actual Result:

App crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2023-10-19.at.11.15.49.AM.mov

MacOS: Desktop

Screen.Recording.2023-10-19.at.11.18.06.AM.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0110ec104becd93e90
• Upwork Job ID: 1715007628320174080
• Last Price Increase: 2023-10-19
• Automatic offers:
• hoangzinh | Reviewer | 27283181
• gadhiyamanan | Reporter | 27283182
• situchan | Contributor | 27283230

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crash on login

What is the root cause of that problem?

After login with a new account ReportActionsView is rendered with reportActions as an empty object briefly

And then the app crashes with this condition because reportActions is {}

App/src/libs/ReportActionsUtils.ts

Line 175 in 229cb5d

const iouRequestActions = reportActions?.filter((action) => action.actionName === CONST.REPORT.ACTIONS.TYPE.IOU && iouRequestTypes.includes(action.originalMessage.type)) ?? [];

What changes do you think we should make in order to solve the problem?

We should safely using _.filter instead of using reportActions?.filter

const iouRequestActions = _.filter(reportActions, (action) => action.actionName === CONST.REPORT.ACTIONS.TYPE.IOU && iouRequestTypes.includes(action.originalMessage.type))

App/src/libs/ReportActionsUtils.ts

Line 175 in 229cb5d

const iouRequestActions = reportActions?.filter((action) => action.actionName === CONST.REPORT.ACTIONS.TYPE.IOU && iouRequestTypes.includes(action.originalMessage.type)) ?? [];

What alternative solutions did you explore? (Optional)

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @robertjchen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[situchan]

@dukenv0307 It's intentional to get rid of _ in TS.

After login with a new account ReportActionsView is rendered with reportActions as an empty object briefly

We should fix this root cause. So there should be no case of reportActions being set to non-array.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0110ec104becd93e90