[HOLD for payment 2023-12-07] [$500] Go back from `Flag as offensive` doesn't display correct report page

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.87-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @suneox
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697654423349679

Action Performed:

1. Go to any public room report exam
2. Hold touch on any chat message select "Flag as offensive"
3. Reload page exam
4. Select back button

Expected Result:

App should display report from Flag as offensive

Actual Result:

App doesn't display report from Flag as offensive

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

az_recorder_20231019_004916.mp4

iOS: Native

iOS: mWeb Safari

RPReplay_Final1697654319.MP4

MacOS: Chrome / Safari

flag-as-offensive-chrome.mp4

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01bff2f94a7065c212
• Upwork Job ID: 1715445279961526272
• Last Price Increase: 2023-10-20
• Automatic offers:
• suneox | Contributor | 27349484

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01bff2f94a7065c212

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[m-natarajan]

Proposal from @suneox

Please re-state the problem that we are trying to solve in this issue.

Go back from Flag as offensive doesn’t display correct report page

What is the root cause of that problem?

In the HeaderWithBackButton of the FlagCommentPage we dont specify a route for the back action

What changes do you think we should make in order to solve the problem?

We should handle onBackButtonPress go to current report from HeaderWithBackButton

    <HeaderWithBackButton
        title={props.translate(‘reportActionContextMenu.flagAsOffensive’)}
        onBackButtonPress={() => Navigation.goBack(ROUTES.REPORT_WITH_ID.getRoute(props.report.reportID))}
    />

What alternative solutions did you explore? (Optional)

[mananjadhav]

@suneox's proposal seems good. quick straight forward fix.

🎀 👀 🎀 C+ reviewed.

[melvin-bot]

Triggered auto assignment to @iwiznia, see https://stackoverflow.com/c/expensify/questions/7972 for more details.