[HOLD for payment 2023-11-09] [$500] Task - Task assignee profile opens when clicking on the header of task report

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.89-4

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to any chat > + > Assign task
3. Create a task with no assignee
4. On the task report, click on the report header
5. Verify that the task details page shows up
6. Repeat Step 1 to 3 with task with an assignee

Expected Result:

Task details modal opens when clicking on the report header of the task with assignee

Actual Result:

Task assignee profile opens instead of task details modal

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Bug6247499_1698072098279.20231023_221048.mp4

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01852a4aad8299505f
• Upwork Job ID: 1716479601614000128
• Last Price Increase: 2023-10-23

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01852a4aad8299505f

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[shubham1206agra]

I am able to repro this.

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Task assignee profile opens when clicking on task report header

What is the root cause of that problem?

Because of this line:

App/src/libs/ReportUtils.js

Lines 2074 to 2077 in 844b3b9

	if (isDM(report) && participantAccountIDs.length === 1) {
	Navigation.navigate(ROUTES.PROFILE.getRoute(participantAccountIDs[0]));
	return;
	}

It navigates to participant or assignee detail when the task has an assignee

What changes do you think we should make in order to solve the problem?

We should change those lines to display the task detail whether there is participant( assignee) is there or not
Change

App/src/libs/ReportUtils.js

Lines 2074 to 2077 in 844b3b9

	if (isDM(report) && participantAccountIDs.length === 1) {
	Navigation.navigate(ROUTES.PROFILE.getRoute(participantAccountIDs[0]));
	return;
	}

to
`

function navigateToDetailsPage(report) {
const participantAccountIDs = lodashGet(report, 'participantAccountIDs', []);
const type = lodashGet(report, 'type', '');

if (isDM(report) && participantAccountIDs.length === 1 && type !== 'task') {
    Navigation.navigate(ROUTES.PROFILE.getRoute(participantAccountIDs[0]));
    return;
}
Navigation.navigate(ROUTES.REPORT_WITH_ID_DETAILS.getRoute(report.reportID));

}

`

What alternative solutions did you explore? (Optional)

[alitoshmatov]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Task - Task assignee profile opens when clicking on the header of task report

What is the root cause of that problem?

This condition is not sufficient since isDM function is returning true for task reports also

App/src/libs/ReportUtils.js

Lines 2074 to 2077 in 844b3b9

	if (isDM(report) && participantAccountIDs.length === 1) {
	Navigation.navigate(ROUTES.PROFILE.getRoute(participantAccountIDs[0]));
	return;
	}

What changes do you think we should make in order to solve the problem?

We should update the condition so that it takes task reports into consideration, like this:

isDM(report) && participantAccountIDs.length === 1 && !isTaskReport(report)

What alternative solutions did you explore? (Optional)

[shubham1206agra]

@FitseTLT @alitoshmatov Thank you for your proposals.
Both have very similar proposals but need more reasoning in their RCA.
Can you both elaborate on why this happens when we only assign during creating a task but not on the task where we have no assignee while creating the task?
And please also post a video too