[HOLD for payment 2023-11-07] [HOLD for payment 2023-11-06] Room - When entering a "Space" while writing Room name "-" is not added

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.92.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Log in to NewDot with a High traffic account that owns a existing Workspace
2. Click on the green + button
3. Click on the "Send Message" option
4. Click the tab 'Room'
5. Type some text and hit "Space"

Expected Result:

When entering the room name, entering a "Space" adds a "-" to the name

Actual Result:

When entering a "Space" while writing Room name "-" is not added

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Bug6253189_1698405030184.Recording__1307.mp4

MacOS: Desktop

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @puneetlath (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[BhuvaneshPatil]

This is because of refactor - #29771

[puneetlath]

@kowczarz would you be able to take a look at this?

[blazejkustra]

Kamil is OOO, I'm on it @puneetlath 😄

[BhuvaneshPatil]

I have made the changes for this. I can work on this if it's fine.

Screen.Recording.2023-10-27.at.6.16.48.PM.mov

[puneetlath]

@BhuvaneshPatil we can make this a $250 job. If you're good with that, please share your proposal.

[aimane-chnaif]

If possible, let's fix these regressions in one PR.
Personally, I suggest to revert it.

[puneetlath]

Ah interesting. If it created that many regressions then I agree it's better to revert.