[HOLD for payment 2023-11-29] [$500] Status - Different chat report opens when clicking on the back button in Status modal

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.3.92-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

Precondition: User has set a status.

1. Go to staging.new.expensify.com
2. Open different chat reports.
3. Click on the status on the top left.
4. Click on the back button.

Expected Result:

The current chat report remains open.

Actual Result:

A different chat report opens.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Bug6253028_1698396389798.20231027_164311.mp4

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f903eb3ac10fe198
• Upwork Job ID: 1717888354588504064
• Last Price Increase: 2023-10-27
• Automatic offers:
• shubham1206agra | Reviewer | 27537929
• dukenv0307 | Contributor | 27537933

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f903eb3ac10fe198

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[namhihi237]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Different chat report opens when clicking on the back button in Status modal

What is the root cause of that problem?

In the StatusPage we pass navigateBackToSettingsPage into onBackButtonPress prop.
In navigateBackToSettingsPage we pass the param shouldPopToTop = true here

What changes do you think we should make in order to solve the problem?

I think we can remove the shouldPopToTop param

        Navigation.goBack(ROUTES.SETTINGS_PROFILE, false)

What alternative solutions did you explore? (Optional)

N/A

[dummy-1111]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When go to status page after navigating several reports, back button navigates to the report other than the current report

What is the root cause of that problem?

When we navigate to status page, we set shouldPopAllStateOnUP to true and go to the page

App/src/pages/home/sidebar/AvatarWithOptionalStatus.js

Line 36 in 1fc2bbc

Navigation.setShouldPopAllStateOnUP();

And when we go back, we call navigate.goBack with shouldPopToTop = true

App/src/pages/settings/Profile/CustomStatus/StatusPage.js

Line 53 in 1fc2bbc

const navigateBackToSettingsPage = useCallback(() => Navigation.goBack(ROUTES.SETTINGS_PROFILE, false, true), []);

This makes the route stack pop to the first page, which is home page.

App/src/libs/Navigation/Navigation.js

Lines 107 to 113 in 1fc2bbc

	if (shouldPopToTop) {
	if (shouldPopAllStateOnUP) {
	shouldPopAllStateOnUP = false;
	navigationRef.current.dispatch(StackActions.popToTop());
	return;
	}
	}

For wide screen devices, we navigate to the last accessed report when navigating to home page

App/src/libs/Navigation/AppNavigator/ReportScreenIDSetter.js

Line 86 in ee5e6de

const reportID = getLastAccessedReportID(reports, !canUseDefaultRooms, policies, isFirstTimeNewExpensifyUser, lodashGet(route, 'params.openOnAdminRoom', false));

We determine the last access report by its lastReadTime.

App/src/libs/ReportUtils.js

Line 553 in ee5e6de

let sortedReports = sortReportsByLastRead(reports);

The problem is here. When we call OpenReport API, lastReadTime isn't updated

This is the root cause

What changes do you think we should make in order to solve the problem?

I think this issue should be fixed in the backend.
OpenReport call should return the updated lastReadTime

What alternative solutions did you explore? (Optional)

We can simply call Navigation.goBack(ROUTES.SETTINGS_PROFILE), that is, call goBack with shouldPopToTop = false

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

A different chat report opens when clicking back button in status modal.

What is the root cause of that problem?

We're setting shouldPopToTop: true when going back from the status page here. We're also calling setShouldPopAllStateOnUP here in the Avatar status.

This is so that:

• If the user navigates to the StatusPage from the Avatar status, they should go back to the LHN (or the last report in the background, in case of wide screen)
• If the user navigates to the StatusPage via deep link (not going through the Avatar status), they should go back to the Profile settings page normally (because in this case setShouldPopAllStateOnUP is not set)

But this causes a side effect, which is this issue, where we go back to a different report, because the report that was open when avatar status is clicked might not be the last read report of the LHN.

What changes do you think we should make in order to solve the problem?

We just need to add a condition, if there's a report open in the background of the status page (in that case there exists a topmost report id), we should go back to that report instead. We can update this to

const topmostReportId = Navigation.getTopmostReportId();
const navigateBackToSettingsPage = useCallback(() => {
        if (topmostReportId) {
            Navigation.goBack(ROUTES.REPORT_WITH_ID.getRoute(topmostReportId))
        } else {
            Navigation.goBack(ROUTES.SETTINGS_PROFILE, false, true);
        }
    }
, [topmostReportId]);

This will keep our intended behavior for using shouldPopToTop, while fixing the side effect that causes this issue.

What alternative solutions did you explore? (Optional)

NA