[HOLD for payment 2023-12-07] [$500] IOU - Inconsistency in Scan split bill IOU preview for creator&Participant

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.94.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Tap fab-Request Money
3. Tap Scan
4. Upload a picture by taking photo
5. Split with any 2 users
6. Tap add to Split
7. Tap split
8. Tap scan request created
9. Enter amount, description and merchant field
10. Tap split
    Note: The description in OIU is displayed
11. Log in with any user with whom you've split the bill
12. Open IOU
    Note: The Merchant in OIU is displayed

Expected Result:

There should not be inconsistency in IOU preview displayed for scan request creator and participant.

Actual Result:

For user who made scan request and split bill with 2 users, description details entered is shown in IOU preview. But for participant of split bill, merchant details entered is shown in IOU preview. There is inconsistency in IOU preview displayed for scan request creator and participant.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen_Recording_20231107_120329_Chrome.mp4

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01890520fc54e620e1
• Upwork Job ID: 1719686303480401920
• Last Price Increase: 2023-11-01
• Automatic offers:
• cubuspl42 | Reviewer | 27750967
• dukenv0307 | Contributor | 27750969

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01890520fc54e620e1

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Split bill preview display description while IOU Preview display merchant

What is the root cause of that problem?

We only show merchant if the request preview is not split bill

App/src/components/ReportActionItem/MoneyRequestPreview.js

Lines 172 to 175 in c8e7ee5

	const shouldShowMerchant =
	!_.isEmpty(requestMerchant) && !props.isBillSplit && requestMerchant !== CONST.TRANSACTION.PARTIAL_TRANSACTION_MERCHANT && requestMerchant !== CONST.TRANSACTION.DEFAULT_MERCHANT;
	const shouldShowDescription = !_.isEmpty(description) && !shouldShowMerchant;

What changes do you think we should make in order to solve the problem?

I think we should also show merchant for split bill by removing the condition !props.isBillSplit and and change the marigin style of merchant text if it's split bill

App/src/components/ReportActionItem/MoneyRequestPreview.js

Line 173 in c8e7ee5

!_.isEmpty(requestMerchant) && !props.isBillSplit && requestMerchant !== CONST.TRANSACTION.PARTIAL_TRANSACTION_MERCHANT && requestMerchant !== CONST.TRANSACTION.DEFAULT_MERCHANT;

Or Update the condition here to

{shouldShowDescription || (shouldShowMerchant && props.isBillSplit) && <Text style={[styles.colorMuted]}>{description || requestMerchant}</Text>}

And here to

shouldShowMerchant && !props.isBillSplit

App/src/components/ReportActionItem/MoneyRequestPreview.js

Line 318 in c8e7ee5

{shouldShowMerchant && (

App/src/components/ReportActionItem/MoneyRequestPreview.js

Line 328 in c8e7ee5

{shouldShowDescription && <Text style={[styles.colorMuted]}>{description}</Text>}

What alternative solutions did you explore? (Optional)

We can prioritize description over merchant

[miljakljajic]

@cubuspl42 any thoughts on the above proposal?