[$500] Workspace - Avatar in chat header does not revert to default avatar after deleting workspace

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.94-0
**Reproducible in staging?:**Y
**Reproducible in production?:**Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
**Issue reported by:**Applause - Internal Team
Slack conversation:

Issue found when executing PR #29554

Action Performed:

1. Go to staging.new.expensify.com
2. Create a workspace and add a custom avatar.
3. Go to the #announce room.
4. Go to workspace settings.
5. Delete the workspace.
   Note that

Expected Result:

The workspace avatar in all part of the app will revert to the default avatar

Actual Result:

The custom workspace avatar in LHN and chat as well as room details page is reverted to the default avatar, except the custom avatar in the room chat header

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6259691_1698858724755.20231101_104908__1_.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @MitchExpensify

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0190689335322f5021

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @robertKozik (External)

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Avatar in chat header does not revert to default avatar after deleting workspace

What is the root cause of that problem?

We use this memo on the outer component to prevent re-renders from parent-renders. That is the same way we used for OptionRowLHNData

App/src/pages/home/HeaderView.js

Line 274 in 3db5ff4

export default memo(

Because report prop is passed from ReportScreen, HeaderView doesn't re-render when it is changed and the avatar of announce or admin depends on the policy but in HeaderView we don't subscribe this from Onyx which means this component doesn't re-render when the workspace avatar is changed.

What changes do you think we should make in order to solve the problem?

We should subscribe policy from Onyx in HeaderView to make this component re-render when the workspace avatar is changed or the workspace is deleted.

policy: {
    key: ({report}) => `${ONYXKEYS.COLLECTION.POLICY}${report.policyID}`
},

OPTION: we can only get some necessary field of policy to make this component doesn't re-render many times. [name, avatar, pendingAction]

Because we use memo on the outer component, we should get report and personalDetails from Onyx instead of passing them from ReportScreen

What alternative solutions did you explore? (Optional)

We can pass policy from ReportScreen to HeaderView and move the memo to inside HeaderView

Result

Screen.Recording.2023-11-02.at.00.27.49.mov

[yh-0218]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Avatar in chat header does not revert to default avatar after deleting workspace

What is the root cause of that problem?

I think this is not relative with policy

The root cause of this problem is that we don't use memo correctly on HeaderView

App/src/pages/home/HeaderView.js

Line 274 in a31933a

export default memo(

What changes do you think we should make in order to solve the problem?

We need to correct memo here

App/src/pages/home/HeaderView.js

Line 274 in a31933a

export default memo(

export default compose(
    withWindowDimensions,
    withLocalize,
    withOnyx({
        guideCalendarLink: {
            key: ONYXKEYS.ACCOUNT,
            selector: (account) => (account && account.guideCalendarLink) || null,
            initialValue: null,
        },
        parentReport: {
            key: ({report}) => `${ONYXKEYS.COLLECTION.REPORT}${report.parentReportID || report.reportID}`,
            selector: reportWithoutHasDraftSelector,
        },
        session: {
            key: ONYXKEYS.SESSION,
        },
    }),
)(
    memo(
        HeaderView
    ),
)

What alternative solutions did you explore? (Optional)

Screen.Recording.2023-11-02.at.12.09.38.AM.mov

[MitchExpensify]

@robertKozik How do these proposals look to you?