[HOLD for payment 2023-12-18] [$500] ReportUtils.shouldReportBeInOptionList will always be falsy for specific reports

[kubabutkiewicz]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

During Typescript migration I noticed that in SidebarUtils module in getOrderedReportIDs function we have allReportActions param which is typed as Record<string, ReportAction[]>. It's used in ReportUtils.shouldReportBeInOptionList function. If we go deeper inside ReportUtils.shouldReportBeInOptionList it will be used in ReportUtils.canAccessReport then there it will be used in ReportActionsUtils.getParentReportAction which expects that allReportActions will be a collection of object no collection of arrays, which could lead into problems. There is no bug which I noticed yet, but I think its worth of checking.

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e1c89ccf309fa85a
• Upwork Job ID: 1721662000620908544
• Last Price Increase: 2023-11-27

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

During Typescript migration I noticed that in SidebarUtils module in getOrderedReportIDs function we have allReportActions param which is typed as Record<string, ReportAction[]>. It's used in ReportUtils.shouldReportBeInOptionList function. If we go deeper inside ReportUtils.shouldReportBeInOptionList it will be used in ReportUtils.canAccessReport then there it will be used in ReportActionsUtils.getParentReportAction which expects that allReportActions will be a collection of object no collection of arrays, which could lead into problems. There is no bug which I noticed yet, but I think its worth of checking.

What is the root cause of that problem?

We use 2 different type for ReportAction field

What changes do you think we should make in order to solve the problem?

Let's see this function

App/src/libs/ReportUtils.js

Line 3245 in bc9cb8f

function canAccessReport(report, policies, betas, allReportActions) {

I saw all places where use this function, It seems allReportActions param is redundant and we should remove this param. It also helps us to avoid conflict about type for this field

What alternative solutions did you explore? (Optional)

[bernhardoj]

allReportActions is passed from the sidebar component so it rerenders every time the report actions change. (more detail: #21406 (comment))

We have a PR that will remove this line of code, so I think we can wait for the PR.

App/src/libs/ReportUtils.js

Lines 3249 to 3251 in aa30ef2

	if (isThread(report) && ReportActionsUtils.isPendingRemove(ReportActionsUtils.getParentReportAction(report, allReportActions))) {
	return false;
	}

[melvin-bot]

@johncschuster Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e1c89ccf309fa85a

[johncschuster]

Triaging