[HOLD for payment 2023-11-17] [$500] The app crashes when taping on link https://staging.new.expensify.com/request/new/participants

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.96.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Launch the app
2. Log in with any account
3. Tap on https://staging.new.expensify.com/request/new/participants

Expected Result:

App is not crashed

Actual Result:

The app crashes when taping on link https://staging.new.expensify.com/request/new/participants

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Screen_Recording_20231106_183139_New.Expensify.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b97b835cfc1fe6d6
• Upwork Job ID: 1721768998901219328
• Last Price Increase: 2023-11-07
• Automatic offers:
• fedirjh | Reviewer | 27552830
• dukenv0307 | Contributor | 27552832
• situchan | Contributor | 27553607

[kbecciv]

Issue is not reproducible in production

RPReplay_Final1699314789.MP4

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @robertjchen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The app crashes when taping on link https://staging.new.expensify.com/request/new/participants

What is the root cause of that problem?

When we go to the participant page directly by deep-link, the iou field on ONYX will be undefined

App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsPage.js

Line 170 in da2c79e

key: ({iou}) => `${ONYXKEYS.COLLECTION.TRANSACTION}${iou.transactionID}`,

So that App crash because we are reading transactionID of underfined

What changes do you think we should make in order to solve the problem?

App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsPage.js

Line 170 in da2c79e

key: ({iou}) => `${ONYXKEYS.COLLECTION.TRANSACTION}${iou.transactionID}`,

we should update like this

            key: ({iou}) => `${ONYXKEYS.COLLECTION.TRANSACTION}${iou?.transactionID || ''}`,

And then App will auto redirect to the step 1 of request flow

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b97b835cfc1fe6d6

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)