[HOLD for payment 2023-12-07] [$500] Bank-Error does not appear under "Company Website" after entering caps "H" in url

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.99-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

1. Launch app
2. Tap profile
3. Tap Workspaces----Workspace
4. Tap Bank account---Update to USD currency
5. Tap Connect manually
6. Enter all fields
7. Tap Continue
8. In company Information page, enter all fields
9. Tap Company Website
10. Change url to caps "https://www.applause.expensifail.com"/
    ("H" in caps)
11. Tap Save&Continue

Expected Result:

In company information page, an error should appear under the "Company Website" input field and the bar below it should turn red.

Actual Result:

In company information page, an error does not appear under the "Company Website" input field and the bar below it is in green instead of red.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6277061_1700039930100.below.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010d45541c5ea54e51
• Upwork Job ID: 1724767635537690624
• Last Price Increase: 2023-11-15
• Automatic offers:
• akinwale | Reviewer | 27754145
• esh-g | Contributor | 27754146

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010d45541c5ea54e51

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

[esh-g]

Proposal

Please re-state the problem

Bank-Error does not appear under "Company Website" after entering caps "H" in url

What is the root cause of the problem?

We are disabling case sensitivity here:

App/src/libs/ValidationUtils.ts

Line 203 in 8872311

return new RegExp(`^${URL_REGEX_WITH_REQUIRED_PROTOCOL}$`, 'i').test(url);

What changes should be made?

We should remove the 'i' attribute to enable case sensitivity

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

I think the expectation in the OP is not correct. Website with uppercase characters in it are completely valid websites, in composer we're also allowing uppercase characters. But when saving the website here we should ideally lowercase it so it will show up nicely in other places where the data is used.

(Note: all browsers also does this, if you type the site in uppercase, no error will show, the browser will just convert to lowercase and navigate you to the site)

What is the root cause of that problem?

We're not lowercasing the website before saving to the back-end

What changes do you think we should make in order to solve the problem?

Lowercase the website before saving to the back-end

To do this, we can add something like this below here

website: values.website.toLowerCase(),

What alternative solutions did you explore? (Optional)

We can consider additionally lowercase the website as soon as the user blurs the website input.

Optionally, we can improve a bit by allowing users to omit the protocol part of the URL and use sanitizeURL method to add the protocol. So users just enter "google.com", it will still work.

[melvin-bot]

📣 @superdev808! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[sgroh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After add a "Company Website" that contains uppercase in the protocol (http, https or ftp), i.e: Http, httpS, of FTP; an error should appear under the "Company Website" input field, also the bar below the input should turn red indicating that is an invalid website.

What is the root cause of that problem?

Exists a function called isValidWebsite that applies a REGEX with the insensitive flag activated. Returning true on URL(s) that should be considered invalid.

What changes do you think we should make in order to solve the problem?

Unfortunately JavaScript do not support have part of the regular expression be case-insensitive. Other languages support it using the (?i:) pattern modifier. On this JavaScript project a case-insensitive modifier is applied to the entire regular expression so to solve the issue one solution is: Add a simple REGEX validation prior the existent return on function isValidWebsite in order to check that the website URL do not have uppercase on the protocol, and return false if positive.

What alternative solutions did you explore? (Optional)

Force the Website URL protocol to be all in lowercase, changing the user input when the focus change, adding this change the function isValidWebsite will receive a "valid" url.