[HOLD for payment 2023-12-12] [$500] Chat - No skeleton loading when scrolling up the chat history offline until the chat is reopened

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.99.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Launch New Expensify app.
2. Log in to HT account.
3. Open a chat that has long chat history.
4. Go offline.
5. Scroll to the top.
6. Return to LHN.
7. Reopen the chat in Step 2 and scroll to the top.

Expected Result:

In Step 5, skeleton placeholder will appear.

Actual Result:

In Step 5, skeleton placeholder does not appear. It only appears when the chat is revisited in Step 7.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6277522_1700054825958.Screen_Recording_20231115_162131_New_Expensify__1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01073572ec47fdb07b
• Upwork Job ID: 1724786009891438592
• Last Price Increase: 2023-11-15
• Automatic offers:
• paultsimura | Contributor | 28015843

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01073572ec47fdb07b

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[paultsimura]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The top report skeleton is not visible when offline.

What is the root cause of that problem?

This happens because we display the top skeleton based on this condition:

App/src/pages/home/report/ReportActionsView.js

Line 262 in 7727150

isLoadingOlderReportActions={props.isLoadingOlderReportActions}

This value should get updated by calling the Report.getOlderActions here. But we have an early return when offline. This was made to avoid endless loop of the Report.getOlderActions call.

App/src/pages/home/report/ReportActionsView.js

Lines 179 to 193 in 7727150

	const loadOlderChats = () => {
	// Only fetch more if we are neither already fetching (so that we don't initiate duplicate requests) nor offline.
	if (props.network.isOffline || props.isLoadingOlderReportActions) {
	return;
	}
	const oldestReportAction = _.last(props.reportActions);
	// Don't load more chats if we're already at the beginning of the chat history
	if (oldestReportAction.actionName === CONST.REPORT.ACTIONS.TYPE.CREATED) {
	return;
	}
	// Retrieve the next REPORT.ACTIONS.LIMIT sized page of comments
	Report.getOlderActions(reportID, oldestReportAction.reportActionID);
	};

What changes do you think we should make in order to solve the problem?

In ReportActionsView:

First, Move (and slightly modify) this code outside of loadOlderChats to the component level:

    const oldestReportAction = _.last(props.reportActions);
    const isLoadedTillBeginning = lodashGet(oldestReportAction, 'actionName', '') === CONST.REPORT.ACTIONS.TYPE.CREATED;

Second, modify the logic for displaying the top skeleton: show it also when offline & the history is not loaded until the beginning.

    isLoadingOlderReportActions={props.isLoadingOlderReportActions || (props.network.isOffline && !isLoadedTillBeginning)}

App/src/pages/home/report/ReportActionsView.js

Line 262 in 7727150

isLoadingOlderReportActions={props.isLoadingOlderReportActions}

What alternative solutions did you explore? (Optional)

[s77rt]

@paultsimura Thanks for the proposal. Your RCA makes sense but the solution does not look good to me. props.network.isOffline && !isLoadedTillBeginning will make isLoadingOlderReportActions evaluates to true even if we are not loading any report action.

[s77rt]

I see this is a regression from #30658 and it's still within the regression period. In this case this should be fixed by the Contributor/Contributor+ @paultsimura / @getusha