[HOLD for payment 2023-12-12] [$500] Personal details - No green check mark and the year is not selected using Enter key

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.2-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

1. Go to URL https://staging.new.expensify.com/
2. Login with any account
3. Go to Settings -> Profile -> Personal details -> Date of birth -> Date -> Year
4. Enter the year manually in the input field -> Tap Enter

Expected Result:

The green mark near the year is present.
The page closes with the data saved.

Actual Result:

There is no green check mark near the year.
The page closes, the new selected year is not saved.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6286963_1700650222106.Recording__6846.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014b429ddfb40b7555
• Upwork Job ID: 1727297908221693952
• Last Price Increase: 2023-11-22
• Automatic offers:
• aimane-chnaif | Reviewer | 27849808
• mkhutornyi | Contributor | 27849810

Issue Owner

Current Issue Owner: @adelekennedy

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014b429ddfb40b7555

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[mkhutornyi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Pressing Enter key on year picker modal closes Date of birth page as well

What is the root cause of that problem?

This was fixed in #30300 but the fix was reverted during TS migration refactor of useKeyboardShortcut component in #29226

What changes do you think we should make in order to solve the problem?

Bring back that change
https://github.com/Expensify/App/pull/30300/files#diff-c8122e6723c6a4dde72bcbf6da39cfdc7d8d35540105e70c6a305d00e63c7943

[aimane-chnaif]

@mkhutornyi's proposal looks good to me.
As the regression period of #29226 is over, we can treat this as new issue.
🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @marcochavezf, see https://stackoverflow.com/c/expensify/questions/7972 for more details.