[HOLD for payment 2024-01-25] [$500] Web - "Bank account" option does not appear in "Wallet"

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.4.-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #32079

Action Performed:

1. Go to settings > wallet
2. Add bank account

Expected Result:

Bank account option appears

Actual Result:

Only debit card option appears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ea0db427c9d793c6
• Upwork Job ID: 1729294846848581632
• Last Price Increase: 2023-12-12

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ea0db427c9d793c6

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[jgddesigns]

Is there a reason why this error doesn't occur in dev, but does occur in staging?

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Only debit card option appears

What is the root cause of that problem?

We're only showing Personal bank account if we can validate the IOU report passed in, based on this condition. In Wallet page, there'll be no IOU report passed in so canUseBusinessBankAccount is always false.

What changes do you think we should make in order to solve the problem?

Always show Personal bank account if the AddPaymentMethodMenu is from WalletPage. This can be done by updating the canUsePersonalBankAccount check to:

• Check if iouReport is empty, if yes always show Personal bank account, only if it's not empty, we'll check other conditions related to the iouReport

isEmpty(iouReport) ||
...rest

• Or use a new prop to indicate it's from wallet page, or more precisely from non-IOU flow

Update: The prop I mentioned has been added via this PR so we can just use it

What alternative solutions did you explore? (Optional)

NA

[kouhei007]

Contributor details
Your Expensify account email: semenovihor95@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~0132b61da48807943c

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!