[HOLD for payment 2023-12-20] [$250][Cleanup] Always use constants for screen names

[roryabraham]

Coming from #31543 (comment)...

Problem

We have two patterns for adding screens in E/App, and we aren't consistent about when a constant should be used for a screen name in SCREENS.ts or not. This leads to unnecessary confusion and inconsistency. The developer has to decide which pattern to follow, and if a constant needs to be added must adjust the navigation stack accordingly in a PR that does not add a new screen.

Solution

Let's clean this up to always use constants for screen names in E/App (from SCREENS.ts).

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fe00e0d9ee39b022
• Upwork Job ID: 1729552664025485312
• Last Price Increase: 2023-11-28
• Automatic offers:
• cubuspl42 | Reviewer | 27871796

[roryabraham]

Marking this as external but not help wanted as @blazejkustra is going to work on this.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01fe00e0d9ee39b022

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

[melvin-bot]

Triggered auto assignment to @puneetlath (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.