[HOLD for payment 2023-12-08] [HOLD for payment 2023-12-07] Contact method - App crashes when removing secondary contact method

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.5-3
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Launch New Expensify app.
2. Go to Settings > Profile > Contact methods.
3. Go to Contact methods > New contact method.
4. Add a new contact method and save.
5. Tap on the new contact.
6. Remove the new contact method.

Expected Result:

App does not crash.

Actual Result:

App crashes.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari -console error
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6294671_1701266891730.Screen_Recording_20231129_210452_One_UI_Home.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @garrettmknight

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @dangrous (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[ZhenjaHorbach]

#28711
The problem is related to this PR

Proposal

Please re-state the problem that we are trying to solve in this issue.

Contact method - App crashes when removing secondary contact method

What is the root cause of that problem?

It looks like when this code is executed, validateCodeFormRef is not available and is equal null
As a result, we turn to a non-existent method

What changes do you think we should make in order to solve the problem?

We can update code like

                        onModalHide={() => {
                            InteractionManager.runAfterInteractions(() => {
                                this.validateCodeFormRef.current && this.validateCodeFormRef.current.focusLastSelected();
                            });
                        }}

App/src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.js

Lines 267 to 271 in 2f9ae2d

	onModalHide={() => {
	InteractionManager.runAfterInteractions(() => {
	this.validateCodeFormRef.current.focusLastSelected();
	});
	}}

Like here

App/src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.js

Line 255 in 2f9ae2d

onEntryTransitionEnd={() => this.validateCodeFormRef.current && this.validateCodeFormRef.current.focus()}

What alternative solutions did you explore? (Optional)

NA

[dangrous]

Ah, from a PR I reviewed I think. Working on a quick fix

[dangrous]

PR has been merged, requested a CP