[HOLD for payment 2024-02-07] [$500] [MEDIUM] Tags: Selected tag in Parent: Child format shows up multiple times in the search result list

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.5.3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #31775

Action Performed:

Precondition:

• The workspace has multiple tags in Parent: Child format added on OD.
• The workspace has more than 8 tags.

1. Log in to ND as employee.
2. Go to the workspace chat > + > Request money.
3. Create a manual request with a tag in Parent: Child format.
4. Click on the expense preview twice to open expense details page.
5. Click on Tag.
6. Search for the selected tag in the search field.

Expected Result:

The selected tag will not show up multiple times.

Actual Result:

The selected tag shows up multiple times.
This issue only happens with tags in Parent: Child format.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6294857_1701277413365.bandicam_2023-11-29_23-43-36-515.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e80f76d4f90d5b88
• Upwork Job ID: 1729913749207519232
• Last Price Increase: 2023-11-29
• Automatic offers:
• FitseTLT | Contributor | 28065674
• jjcoffee | Contributor | 28116028

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e80f76d4f90d5b88

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[ZhenjaHorbach]

@FitseTLT

It looks like a regression
Or not
But obviously on your part)

[FitseTLT]

Yep regression

Need to take the backslash cleaning code to here

App/src/libs/PolicyUtils.ts

Lines 187 to 188 in 70813db

	function getTagList(policyTags: OnyxCollection<PolicyTags>, tagKey: string) {
	if (Object.keys(policyTags ?? {})?.length === 0) {

[FitseTLT]

But @jjcoffee Can we utilize migrateOnyx here to centralize cleaning of the policyTags so that we can ensure the policyTags are the cleaned version everywhere in the App to avoid future regressions ??

[barros001]

How does one add tags to a workspace? I can go to OldDot but I can only add tags to my personal workspace and I can't really find it on NewDot.