[HOLD for payment 2023-12-28] [$500] Send money - Bank account option is not present in Pay with Expensify menu

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.5-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to 1:1 DM
3. Click + > Send money
4. Select USD currency and enter an amount > Click Next
5. Click Pay with Expensify

Expected Result:

Bank account option will be present in Pay with Expensify menu

Actual Result:

Bank account option is not present in Pay with Expensify menu

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6295100_1701288930404.bandicam_2023-11-30_03-10-17-567.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01782e16325ea5e0f2
• Upwork Job ID: 1729983421600763904
• Last Price Increase: 2023-11-29
• Automatic offers:
• aimane-chnaif | Reviewer | 27911758
• dukenv0307 | Contributor | 27911760

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01782e16325ea5e0f2

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

In SettlementButton in the send money flow, we don't pass in the iouReport, so based on this condition, it will not show the personal bank account.

What changes do you think we should make in order to solve the problem?

In the send money flow, we need to pass the iouType to SettlementButton and subsequently to AddPaymentMethodMenu. If the iouType is CONST.IOU.TYPE.SEND, we can allow the personal bank account to show.

We can add that condition to here, or can extract to a canUsePersonalBankAccount variable (similar pattern to the existing canUseBusinessBankAccount variable)

What alternative solutions did you explore? (Optional)

Pass a boolean, or a iouReport with only the type field, which can be used to indicate it's a send money request in AddPaymentMethodMenu.

[trjExpensify]

Hm, @kevinksullivan @joekaufmanexpensify can you guys chime in on this one?

1. My personal workspace currency is USD
2. I don't have a wallet enabled
3. I send money in USD
4. I tap Pay with Expensify on the confirmation screen
5. I see a debit card option?

Why aren't I prompted here to go through the flow and enable the wallet?

CC: @mountiny as well maybs from Bottom Up!

[mountiny]

Bank account option will be present in Pay with Expensify menu

There should be no business bank account option when sending money 1:1, but there should be one for personal bank account

@dukenv0307 solution is right except we do not want the business bank account but personal one here, we only check for hte IOU report

App/src/components/AddPaymentMethodMenu.js

Lines 82 to 92 in a83a35d

	...(ReportUtils.isIOUReport(iouReport)
	? [
	{
	text: translate('common.personalBankAccount'),
	icon: Expensicons.Bank,
	onSelected: () => {
	onItemSelected(CONST.PAYMENT_METHODS.PERSONAL_BANK_ACCOUNT);
	},
	},
	]
	: []),

but at this point there is no IOU report created yet so the option is not added

[dukenv0307]

@dukenv0307 solution is right except we do not want the business bank account but personal one here, we only check for the IOU report

Thanks @mountiny for point out the right expectation here. Proposal updated to cover the case of personal bank account.