[$500] Chat - After selecting "here" from suggestion list, the suggestion box is opened

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.6-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Pre-condition : Must have user with 'here' in the display name.

1. Go to https://staging.new.expensify.com/
2. Tap on a report
3. Enter @ in compose box
   4.Select "here" from suggestion list

Expected Result:

After selecting "here" from suggestion list, the suggestion box must be closed

Actual Result:

After selecting "here" from suggestion list, the suggestion box is opened showing contact with "here" display name

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6296214_1701362159518.az_recorder_20231130_210049.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010fc871e1309cdbb5
• Upwork Job ID: 1740328328014270464
• Last Price Increase: 2024-02-14

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[paultsimura]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When entering @here, the suggestions are reopened.

What is the root cause of that problem?

If this is not an expected behavior – it looks like a regression from #30217
We now allow searching the suggestion by 2 words and do not handle a specific reserved keyword – @here.

What changes do you think we should make in order to solve the problem?

To solve it, we should skip the multi-word calculation in case the first word is @here:

} else if (secondToLastWord && secondToLastWord !== "@here" && secondToLastWord.startsWith('@') && secondToLastWord.length > 1) {

App/src/pages/home/report/ReportActionCompose/SuggestionMention.js

Line 215 in 7f00bff

} else if (secondToLastWord && secondToLastWord.startsWith('@') && secondToLastWord.length > 1) {

What alternative solutions did you explore? (Optional)

[sakluger]

@graylewis @allroundexperts, the above proposal says that your PR for #30217 may have caused this regression, do you think that's right?

@situchan this also seems related (or at least very similar) to the issue you just fixed for #32214, and your PR there didn't fix this one. Are they related, or just similar?

[allroundexperts]

I think the PR that @situchan did should have fixed this as well. @situchan Can you confirm?

[situchan]

Seems like this is another edge case where user display name includes "here"

[allroundexperts]

Hm... But the root cause is the same as previous bug, right?

[situchan]

yes, both issues are regression from #30217

[graylewis]

The first issue is definitely caused by my solution (#32214) (to me this seems more like a UX nit-pick than a bug. If you start typing after selecting the mention the suggestion goes away). However this issue seems like either an edge case that wasn't considered in the solution for #32214, or just a duplicate of that issue.

[situchan]

Ideally, #31435 should have been reverted at the time of deploy blocker.
But we applied patch (more like UX improvement) instead of revert in #32227. This actually didn't fix the root cause of regression caused by #31435.
So I'd say bug demoted to NAB by fixing non-display name cases. Still remaining in this edge case of "here" being contained in display name.

[allroundexperts]

It's a weird situation tbh. @situchan Can you maybe raise a PR for this since you applied the previous patch as well?