[SMARTSCAN] [$500] LOW: Android - Scan-When adding big image, thumbnail display is not clear, image distorted

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.9-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

1. Launch app
2. Tap fab---Request money--Scan
3. Upload below given image
4. Select a user
5. Tap request
6. Tap request created
7. Note the thumbnail receipt

Expected Result:

When adding big image, thumbnail display must be clear.

Actual Result:

When adding big image as scan receipt, thumbnail display is not clear, image distorted.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0122f62b0e85d3a0e6
• Upwork Job ID: 1732723141179482112
• Last Price Increase: 2023-12-07

Issue Owner

Current Issue Owner: @Julesssss

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0122f62b0e85d3a0e6

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[ZhenjaHorbach]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Scan-When adding big image, thumbnail display is not clear, image distorted

What is the root cause of that problem?

This is actually expected behavior
In addition to the original images
We use thumbnail versions
The height of which is (1024)
And if we have such a long image
We get such funny values (37x1024)

What changes do you think we should make in order to solve the problem?

The most important thing is we need to have access to better images
Which are stored on the backend
And use them if we have problems with image quality (We can evaluate quality using Image.getSize )

App/src/libs/ReceiptUtils.ts

Line 51 in 10727a7

return {thumbnail: `${path}.1024.jpg`, image: path};

---

But from the front side we can use the original image in case, for example, thumbnail photo width is less than 200 pixels (Or we can calculate the aspect ratio If our image is too long, then there is no point in showing thumbnail)

For this, we can add new conditions and use Image

const [isBlurryThumbnail,setBlurryThumbnail] = useState(false)

	Image.getSize(thumbnailSource, (width, height) => {
		if(width < 200) {
		    setBlurryThumbnail(true)
		}
	});
	
	

App/src/components/ReportActionItem/ReportActionItemImage.js

Lines 49 to 73 in 10727a7

	function ReportActionItemImage({thumbnail, image, enablePreviewModal, transaction, isLocalFile}) {
	const styles = useThemeStyles();
	const {translate} = useLocalize();
	const imageSource = tryResolveUrlFromApiRoot(image || '');
	const thumbnailSource = tryResolveUrlFromApiRoot(thumbnail || '');
	const isEReceipt = !_.isEmpty(transaction) && TransactionUtils.hasEReceipt(transaction);
	let receiptImageComponent;
	if (isEReceipt) {
	receiptImageComponent = (
	<View style={[styles.w100, styles.h100]}>
	<EReceiptThumbnail transactionID={transaction.transactionID} />
	</View>
	);
	} else if (thumbnail && !isLocalFile) {
	receiptImageComponent = (
	<ThumbnailImage
	previewSourceURL={thumbnailSource}
	style={[styles.w100, styles.h100]}
	isAuthTokenRequired
	shouldDynamicallyResize={false}
	/>
	);
	} else {

And then if isBlurryThumbnail is true we will use imageSource instead thumbnailSource

App/src/components/ReportActionItem/ReportActionItemImage.js

Line 67 in 10727a7

previewSourceURL={thumbnailSource}

What alternative solutions did you explore? (Optional)

NA

[Ollyws]

@ZhenjaHorbach Thanks for the proposal but it seems like a bit of a workaround.
I think a better solution would be to refine the thumbnail cropping on the backend.

@abekkala Could we have an internal engineer take a look? Thanks!