[HOLD for payment 2024-01-11] [$500] Settings - No popup on view the code option

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.11-23
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Open the app
2. Open settings -> about
3. Right click / long press on 'View the code'
4. Observe that no popup is displayed
5. Similarly right click / long press on 'View open jobs' and observe that 'Copy URL to clipboard' popup is displayed

Expected Result:

App should display 'Copy URL to clipboard' popup on right click / long press on external links

Actual Result:

App does not display 'Copy URL to clipboard' popup on right click / long press on 'View the code' external link

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6311252_1702447002565.windows_chrome_-_no_popup_on_view_the_code.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017225d7bfab54454a
• Upwork Job ID: 1734926270628777984
• Last Price Increase: 2023-12-13
• Automatic offers:
• abdulrahuman5196 | Reviewer | 28067055
• ZhenjaHorbach | Contributor | 28067056

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017225d7bfab54454a

[melvin-bot]

Triggered auto assignment to @peterdbarkerUK (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[paultsimura]

Proposal

Please re-state the problem that we are trying to solve in this issue.

On right-clicking the "View the code" item, no custom popup is shown.

What is the root cause of that problem?

The "View the code" item is not a PressableWithSecondaryInteraction, compared to the "View open jobs".

What changes do you think we should make in order to solve the problem?

We need to wrap the "View the code" item in PressableWithSecondaryInteraction with the relevant action (copy URL).

What alternative solutions did you explore? (Optional)

[ZhenjaHorbach]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Settings - No popup on view the code option

What is the root cause of that problem?

We don't pass link(used to display popup) for viewTheCode

App/src/pages/settings/AboutPage/AboutPage.js

Lines 61 to 68 in 1fd0989

	{
	translationKey: 'initialSettingsPage.aboutPage.viewTheCode',
	icon: Expensicons.Eye,
	iconRight: Expensicons.NewWindow,
	action: () => {
	Link.openExternalLink(CONST.GITHUB_URL);
	},
	},

Unlike viewOpenJobs

App/src/pages/settings/AboutPage/AboutPage.js

Lines 69 to 77 in 1fd0989

	{
	translationKey: 'initialSettingsPage.aboutPage.viewOpenJobs',
	icon: Expensicons.MoneyBag,
	iconRight: Expensicons.NewWindow,
	action: () => {
	Link.openExternalLink(CONST.UPWORK_URL);
	},
	link: CONST.UPWORK_URL,
	},

What changes do you think we should make in order to solve the problem?

We can update code and add link param like

            {
                translationKey: 'initialSettingsPage.aboutPage.viewTheCode',
                icon: Expensicons.Eye,
                iconRight: Expensicons.NewWindow,
                action: () => {
                    Link.openExternalLink(CONST.GITHUB_URL);
                },
                link: CONST.GITHUB_URL,
            },

As a result

What alternative solutions did you explore? (Optional)

NA

[apps-ferreiro]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Settings - No popup on view the code option

What is the root cause of that problem?

The link property is missing in the base menu items:

App/src/pages/settings/AboutPage/AboutPage.js

Lines 62 to 77 in 2782381

	translationKey: 'initialSettingsPage.aboutPage.viewTheCode',
	icon: Expensicons.Eye,
	iconRight: Expensicons.NewWindow,
	action: () => {
	Link.openExternalLink(CONST.GITHUB_URL);
	},
	},
	{
	translationKey: 'initialSettingsPage.aboutPage.viewOpenJobs',
	icon: Expensicons.MoneyBag,
	iconRight: Expensicons.NewWindow,
	action: () => {
	Link.openExternalLink(CONST.UPWORK_URL);
	},
	link: CONST.UPWORK_URL,
	},

Which is the one that triggers:

App/src/pages/settings/AboutPage/AboutPage.js

Line 91 in 2782381

onSecondaryInteraction: !_.isEmpty(item.link) ? (e) => ReportActionContextMenu.showContextMenu(CONTEXT_MENU_TYPES.LINK, e, item.link, popoverAnchor) : undefined,

What changes do you think we should make in order to solve the problem?

Pass the link value CONST.GITHUB_URL

What alternative solutions did you explore? (Optional)

[ishpaul777]

Hi @peterdbarkerUK, I noticed this was a regression from my previous pull request a while back. Upon realizing this, I offered to fix it here. It seems like @joelbettner might have missed the comment. If you agree, i'll raise a quick PR to address the issue, without compensation ofc.